Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21591: Check for record level item type issues too

Browse source 
To test:
1 - sudo koha-mysql kohadev
2 - UPDATE biblioitems SET itemtype = NULL where biblionumber = 1
3 - UPDATE items SET itype = NULL where biblionumber = 1
4 - perl misc/maintenance/search_for_data_inconsistencies.pl
5 - Notice warnings
6 - Apply patch
7 - Undefined itemtype on bibliolevel is now warned
7 - Test also with itype=""

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2018-10-17 19:56:12 +00:00 committed by Jonathan Druart
parent 488a9fc8ed
commit 6beda5cf1d
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
misc/maintenance/search_for_data_inconsistencies.pl
View file

@ -55,14 +55,21 @@ use C4::Biblio;
{
if ( C4::Context->preference('item-level_itypes') ) {
my $items_without_itype = Koha::Items->search( { itype => undef } );
my $items_without_itype = Koha::Items->search( { -or => [itype => undef,itype => ''] } );
if ( $items_without_itype->count ) {
new_section("Items do not have itype defined");
while ( my $item = $items_without_itype->next ) {
new_item(
sprintf "Item with itemnumber=%s does not have a itype value, biblio's item type will be used (%s)",
$item->itemnumber, $item->biblioitem->itemtype
);
if (defined $item->biblioitem->itemtype && $item->biblioitem->itemtype ne '' ) {
new_item(
sprintf "Item with itemnumber=%s does not have a itype value, biblio's item type will be used (%s)",
$item->itemnumber, $item->biblioitem->itemtype
);
} else {
new_item(
sprintf "Item with itemnumber=%s does not have a itype value, additionally no item type defined for biblionumber=%s",
$item->itemnumber, $item->biblioitem->biblionumber
);
}
}
new_hint("The system preference item-level_itypes expects item types to be defined at item level");
}
@ -83,7 +90,7 @@ use C4::Biblio;
my @itemtypes = Koha::ItemTypes->search->get_column('itemtype');
if ( C4::Context->preference('item-level_itypes') ) {
my $items_with_invalid_itype = Koha::Items->search( { itype => { not_in => \@itemtypes } } );
my $items_with_invalid_itype = Koha::Items->search( { -and => [itype => { not_in => \@itemtypes }, itype => { '!=' => '' }] } );
if ( $items_with_invalid_itype->count ) {
new_section("Items have invalid itype defined");
while ( my $item = $items_with_invalid_itype->next ) {