Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11007: Drop column aqorders.cancelledby

Browse source 
It seems that this column has never been used.

Test plan:
1/ Execute the updatedatabase entry.
2/ git grep cancelledby should not return occurrence in the code (except
in Koha/Schema/*
3/ prove t/db_dependent/Acquisition.t should return green.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I couldn't find any trace of this column being used.
Passes tests and QA script, updates all necessary files.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2014-07-18 12:48:57 +02:00 committed by Tomas Cohen Arazi
parent c95a4b0f84
commit 6c1e10db22
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
installer/data/mysql/kohastructure.sql
View file

@ -3024,7 +3024,6 @@ CREATE TABLE `aqorders` ( -- information related to the basket line items
`freight` decimal(28,6) default NULL, -- shipping costs (not used) `freight` decimal(28,6) default NULL, -- shipping costs (not used)
`unitprice` decimal(28,6) default NULL, -- the actual cost entered when receiving this line item `unitprice` decimal(28,6) default NULL, -- the actual cost entered when receiving this line item
`quantityreceived` smallint(6) NOT NULL default 0, -- the quantity that have been received so far `quantityreceived` smallint(6) NOT NULL default 0, -- the quantity that have been received so far
`cancelledby` varchar(10) default NULL, -- not used? always NULL
`datecancellationprinted` date default NULL, -- the date the line item was deleted `datecancellationprinted` date default NULL, -- the date the line item was deleted
`order_internalnote` mediumtext, -- notes related to this order line, made for staff `order_internalnote` mediumtext, -- notes related to this order line, made for staff
`order_vendornote` mediumtext, -- notes related to this order line, made for vendor `order_vendornote` mediumtext, -- notes related to this order line, made for vendor

10
installer/data/mysql/updatedatabase.pl
View file

@ -8867,6 +8867,16 @@ if ( CheckVersion($DBversion) ) {
SetVersion($DBversion); SetVersion($DBversion);
} }
$DBversion = "3.17.00.XXX";
if ( CheckVersion($DBversion) ) {
$dbh->do(q|
ALTER TABLE aqorders DROP COLUMN cancelledby;
|);
print "Upgrade to $DBversion done (Bug 11007 - DROP column aqorders.cancelledby)\n";
SetVersion($DBversion);
}
=head1 FUNCTIONS =head1 FUNCTIONS
=head2 TableExists($table) =head2 TableExists($table)

3
t/db_dependent/Acquisition.t
View file

@ -324,7 +324,6 @@ my @expectedfields = qw(
freight freight
unitprice unitprice
quantityreceived quantityreceived
cancelledby
datecancellationprinted datecancellationprinted
supplierreference supplierreference
purchaseordernumber purchaseordernumber
@ -400,7 +399,6 @@ my @base_expectedfields = qw(
ecost ecost
uncertainprice uncertainprice
marc marc
cancelledby
url url
isbn isbn
copyrightdate copyrightdate
@ -565,7 +563,6 @@ ok(
datereceived datereceived
orderstatus orderstatus
supplierreference supplierreference
cancelledby
isbn isbn
copyrightdate copyrightdate
gstrate gstrate