Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30848: Fix issue exposed by unit tests

Browse source 
This patch changes the 'map' to a simple for loop so that we can easily
map multiple subfields to a field without overwriting the first previous
subfields in the structure.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2022-06-13 14:26:33 +01:00 committed by Tomas Cohen Arazi
parent 6b04e3e18f
commit 6c381c4b22
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Koha/Filter/MARC/ExpandCodedFields.pm
View file

@ -114,14 +114,8 @@ sub _getCodedFields {
my $cached = $cache->get_from_cache( $cache_key, { unsafe => 1 } );
return $cached if $cached;
my $coded_fields = {
map {
$_->tagfield => {
$_->tagsubfield => {
'authorised_value' => $_->authorised_value
}
}
} Koha::MarcSubfieldStructures->search(
my $coded_fields = {};
my @fields = Koha::MarcSubfieldStructures->search(
{
frameworkcode => $frameworkcode,
authorised_value => { '>' => '' }
@ -130,8 +124,10 @@ sub _getCodedFields {
columns => [ 'tagfield', 'tagsubfield', 'authorised_value' ],
order_by => [ 'tagfield', 'tagsubfield' ]
}
)->as_list
};
)->as_list;
for my $field (@fields) {
$coded_fields->{ $field->tagfield }->{ $field->tagsubfield }->{'authorised_value'} = $field->authorised_value;
}
$cache->set_in_cache( $cache_key, $coded_fields );
return $coded_fields;