Bug 29894: (follow-up) Update notice terms

Register and Derigister didn't sound right, in reality we we enabling
and disabling 2FA for the user so I think those terms are more
understandable.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Koha/Auth/TwoFactorAuth.pm

@@ -25,8 +25,8 @@ use Koha::Exceptions::Patron;
 
 use base qw( Auth::GoogleAuth );
 
-use constant CONFIRM_NOTICE_REG => '2FA_REGISTER';
-use constant CONFIRM_NOTICE_DEREG => '2FA_DEREGISTER';
+use constant CONFIRM_NOTICE_REG => '2FA_ENABLE';
+use constant CONFIRM_NOTICE_DEREG => '2FA_DISABLE';
 
 =head1 NAME
 

installer/data/mysql/atomicupdate/bug_29894.pl

@@ -2,15 +2,15 @@ use Modern::Perl;
 
 return {
     bug_number => 29894,
-    description => "Add 2FA (de)registering notices",
+    description => "Add 2FA (de)enabling notices",
     up => sub {
         my ($args) = @_;
         my ($dbh, $out) = @$args{qw(dbh out)};
         $dbh->do( q{
 INSERT IGNORE INTO letter
 (module, code, branchcode, name, is_html, title, content, message_transport_type, lang) VALUES
-('members', '2FA_DEREGISTER', '', 'Confirmation of deregistering two factor authentication', 1, 'Confirmation of deregistering two factor authentication', '<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>\r\n<p>This is to confirm that we deregistered two factor authentication for you.</p>\r\n<p>If you did not deregister, someone else may be using your account. Please contact technical support.</p>\r\n<p>Your library</p>', 'email', 'default'),
-('members', '2FA_REGISTER', '', 'Confirmation of registering two factor authentication', 1, 'Confirmation of registering two factor authentication', '<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>\r\n<p>This is to confirm that we registered two factor authentication for you.</p>\r\n<p>If you did not register, someone else may be using your account. Please contact technical support.</p>\r\n<p>Your library</p>', 'email', 'default')
+('members', '2FA_DISABLE', '', 'Confirmation of disabling two factor authentication', 1, 'Confirmation of disabling two factor authentication', '<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>\r\n<p>This is to confirm that someone disabled two factor authentication on your account.</p>\r\n<p>If you did not do this, someone else may be using your account. Please contact technical support.</p>\r\n<p>Your library</p>', 'email', 'default'),
+('members', '2FA_ENABLE', '', 'Confirmation of enabling two factor authentication', 1, 'Confirmation of enabling two factor authentication', '<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>\r\n<p>This is to confirm that someone enabled two factor authentication on your account.</p>\r\n<p>If you did not do this, someone else may be using your account. Please contact technical support.</p>\r\n<p>Your library</p>', 'email', 'default')
         });
     },
 };

installer/data/mysql/en/mandatory/sample_notices.yml

@@ -1634,29 +1634,29 @@ tables:
             - "Notes: <<recalls.recallnotes>>"
 
         - module: members
-          code: 2FA_DEREGISTER
+          code: 2FA_DISABLE
           branchcode: ""
-          name: "Confirmation of deregistering two factor authentication"
+          name: "Confirmation of disabling two factor authentication"
           is_html: 1
-          title: "Confirmation of deregistering two factor authentication"
+          title: "Confirmation of disabling two factor authentication"
           message_transport_type: email
           lang: default
           content:
             - "<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>"
-            - "<p>This is to confirm that we deregistered two factor authentication for you.</p>"
-            - "<p>If you did not deregister, someone else may be using your account. Please contact technical support.</p>"
+            - "<p>This is to confirm that someone disabled two factor authentication on your account.</p>"
+            - "<p>If you did not do this, someone else may be using your account. Please contact technical support.</p>"
             - "<p>Your library</p>"
 
         - module: members
-          code: 2FA_REGISTER
+          code: 2FA_ENABLE
           branchcode: ""
-          name: "Confirmation of registering two factor authentication"
+          name: "Confirmation of enabling two factor authentication"
           is_html: 1
-          title: "Confirmation of registering two factor authentication"
+          title: "Confirmation of enabling two factor authentication"
           message_transport_type: email
           lang: default
           content:
             - "<p>Dear [% borrower.firstname %] [% borrower.surname %],</p>"
-            - "<p>This is to confirm that we registered two factor authentication for you.</p>"
-            - "<p>If you did not register, someone else may be using your account. Please contact technical support.</p>"
+            - "<p>This is to confirm that someone enabled two factor authentication on your account.</p>"
+            - "<p>If you did not do this, someone else may be using your account. Please contact technical support.</p>"
             - "<p>Your library</p>"