Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31540: Exclude expired holds from the reminder job

Browse source 
Some libraries don't want to auto-cancel holds, but we should not remind
a patron about a hold which has expired.

To test:
1 - Place a hold for a patron
2 - Set it waiting
3 - Run the holds reminder script in the future
    perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v
4 - Note the holds would be reminded
5 - Set expirationdate for the hold less than today
    UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY);
6 - Run the remidner cron again
7 - No holds trigger!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4c3d18091d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Nick Clemens 2022-09-12 14:35:24 +00:00 committed by Lucas Gass
parent 3d63dd6eb7
commit 6e3ff69730
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
misc/cronjobs/holds/holds_reminder.pl
View file

@ -260,6 +260,7 @@ foreach my $branchcode (@branchcodes) { #BEGIN BRANCH LOOP
my $reserves = Koha::Holds->search({
waitingdate => {$comparator => $waiting_since },
'me.branchcode' => $branchcode,
'-or' => [ expirationdate => undef, expirationdate => { '>' => \'CURDATE()' } ]
},{ prefetch => 'patron' });
$verbose and warn "No reserves found for $branchcode\n" unless $reserves->count;