Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35890: Add tests for AutoLocation

Browse source 
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 85717a99c7ba20d3bef8e9ba15df6d0a86f368c6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Jonathan Druart 2024-01-25 09:36:01 +01:00 committed by Fridolin Somers
parent bfbe854b6c
commit 6e4711d925
1 changed files with 52 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
t/db_dependent/Auth.t
View file

@ -7,7 +7,7 @@ use CGI qw ( -utf8 );
use Test::MockObject;
use Test::MockModule;
use List::MoreUtils qw/all any none/;
use Test::More tests => 19;
use Test::More tests => 20;
use Test::Warn;
use t::lib::Mocks;
use t::lib::TestBuilder;
@ -1268,6 +1268,57 @@ subtest 'checkpw() return values tests' => sub {
};
};
subtest 'AutoLocation' => sub {
plan tests => 6;
$schema->storage->txn_begin;
t::lib::Mocks::mock_preference( 'AutoLocation', 0 );
my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { flags => 1 } } );
my $password = 'password';
t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
$patron->set_password( { password => $password } );
my $cgi_mock = Test::MockModule->new('CGI');
$cgi_mock->mock( 'request_method', sub { return 'POST' } );
my $cgi = CGI->new;
my $auth = Test::MockModule->new('C4::Auth');
# Simulating the login form submission
$cgi->param( 'userid', $patron->userid );
$cgi->param( 'password', $password );
$ENV{REMOTE_ADDR} = '127.0.0.1';
my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, 0, { catalogue => 1 }, 'intranet' );
is( $userid, $patron->userid );
my $template;
t::lib::Mocks::mock_preference( 'AutoLocation', 1 );
# AutoLocation: "Require staff to log in from a computer in the IP address range specified by their library (if any)"
$patron->library->branchip('')->store; # There is none, allow access from anywhere
( $userid, $cookie, $sessionID, $flags, $template ) =
C4::Auth::checkauth( $cgi, 0, { catalogue => 1 }, 'intranet' );
is( $userid, $patron->userid );
is( $template, undef );
$patron->library->branchip('1.2.3.4')->store;
( $userid, $cookie, $sessionID, $flags, $template ) =
C4::Auth::checkauth( $cgi, 0, { catalogue => 1 }, 'intranet', undef, undef, { do_not_print => 1 } );
is( $template->{VARS}->{wrongip}, 1 );
$patron->library->branchip('127.0.0.1')->store;
( $userid, $cookie, $sessionID, $flags, $template ) =
C4::Auth::checkauth( $cgi, 0, { catalogue => 1 }, 'intranet' );
is( $userid, $patron->userid );
is( $template, undef );
$schema->storage->txn_rollback;
};
sub set_weak_password {
my ($patron) = @_;
my $password = 'password';