Bug 5229: Remove system preference 'OPACItemsResultsDisplay'

We dropped it on bug 12561 when removing the non-XSLT view. This feature
has never been implemented for XSLT views and the pref must then be
removed.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

C4/UsageStats.pm

@@ -346,7 +346,6 @@ sub _shared_preferences {
         defaultSortField
         displayFacetCount
         OPACdefaultSortField
-        OPACItemsResultsDisplay
         expandedSearchOption
         IntranetNumbersPreferPhrase
         OPACNumbersPreferPhrase

installer/data/mysql/atomicupdate/bug_5229.pl

@@ -0,0 +1,11 @@
+use Modern::Perl;
+
+return {
+    bug_number => "5229",
+    description => "Remove system preference 'OPACItemsResultsDisplay'",
+    up => sub {
+        my ($args) = @_;
+        my ($dbh, $out) = @$args{qw(dbh out)};
+        $dbh->do(q{DELETE FROM systempreferences WHERE variable='OPACItemsResultsDisplay'});
+    },
+}

opac/opac-search.pl

@@ -763,7 +763,6 @@ for (my $i=0;$i<@servers;$i++) {
 
             $template->param(
                 SEARCH_RESULTS => \@newresults,
-                OPACItemsResultsDisplay => (C4::Context->preference("OPACItemsResultsDisplay")),
                 suppress_result_number => $hide,
                             );
             if (C4::Context->preference("OPACLocalCoverImages")){