Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 14801: Fix Reserves.t -- Follow-up for ChargeReserveFee

Browse source 
The problem making some tests fail, actually was the unneeded addition
of zero accountline records by ChargeReserveFee, called by AddReserve.
The balance is still zero, but a test like !$var responds differently
when var is 0.00 instead of 0 or undef.

This patch adjusts the test in ChargeReserveFee in order to prevent
adding these records with 0.00.
The first patch that adjusts the tests in Reserves.t is not strictly
needed anymore, but can stay.

Test plan:
[1] Run t/db_dependent/Reserves.t
[2] Run t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
This commit is contained in:
Marcel de Rooy 2015-09-14 11:11:11 +02:00 committed by Tomas Cohen Arazi
parent 8b710d62d1
commit 70133ef343
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
C4/Reserves.pm
View file

@ -650,7 +650,7 @@ sub GetOtherReserves {
sub ChargeReserveFee {
my ( $borrowernumber, $fee, $title ) = @_;
return if !$fee;
return if !$fee || $fee==0; # the last test is needed to include 0.00
my $accquery = qq{
INSERT INTO accountlines ( borrowernumber, accountno, date, amount, description, accounttype, amountoutstanding ) VALUES (?, ?, NOW(), ?, ?, 'Res', ?)
};