Bug 34625: Fix search engine configuration tables header problem

This patch corrects the JavaScript which allows DataTables to be created
and destroyed based on which tab is clicked on the search engine
configuration page. When you click from one tab to the other, the
original tab's DataTable should be destroyed and the new tab's DataTable
initialized.

To test, apply the patch and go to Administration -> Search engine
configuration (Elasticsearch)

- The page should load with the "Search fields" tab enabled and the
  DataTable initialized: Sorting and filtering should work. If you
  scroll down the page the floating table header should be correct.
- Switch to the "Bibliographic records" tab. This table should have
  filtering enabled, and the floating table header should work when you
  scroll down the page.
- The same should be true for the "Authorities" tab.
- Return to the "Search fields" tab to confirm that the DataTable is
  still working as expected.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit cac122b611)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js

@@ -42,8 +42,8 @@ $(document).ready(function () {
     tableInit( "", "search_fields");
 
     $("a[data-toggle='tab']").on("shown.bs.tab", function (e) {
-        var oldtabid = $(e.relatedTarget).data("tab");
-        var newtabid = $(e.target).data("tab");
+        var oldtabid = $(e.relatedTarget).data("tabname");
+        var newtabid = $(e.target).data("tabname");
         tableInit( oldtabid, newtabid );
     });