Browse Source

Bug 15079: Batch Delete Records Error

When using the batch deletion tool, if the script attempts to delete an
undeletable item, the script will die with the error:

Label not found for "next BIBLIONUMBER" at
/usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172.

Test Plan:
1) Attempt to batch delete a record with an item that cannot be deleted
2) Note error
3) Apply this patch
4) Repeat step 1
5) Note the error no longer occurs

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Follow comment 5 to reproduce the issue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have not tested this patch, but looking at the code it is obviously a mistake.
If an error occured, we rollback and skip this record.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
3.22.x
Kyle Hall 9 years ago
committed by Tomas Cohen Arazi
parent
commit
706a31b50d
  1. 2
      tools/batch_delete_records.pl

2
tools/batch_delete_records.pl

@ -169,7 +169,7 @@ if ( $op eq 'form' ) {
error => ($@ ? $@ : $error),
};
$dbh->rollback;
next BIBLIONUMBER;
next RECORD_IDS;
}
}

Loading…
Cancel
Save