Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 19463: Reduce the chance to have TestBuilder generate twice the same value

Browse source 
When an id is generated by TestBuilder (branchcode for instance) and the
size of the generated string is 1, we have too many chances to get
"Violation of unique constraint in Branch".

This patch increases the number of retries to 5.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended to make room for follow-up.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2017-10-17 11:29:06 -03:00
parent 6bf390f38c
commit 708d02047d
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
t/lib/TestBuilder.pm
View file

@ -188,8 +188,8 @@ sub _buildColumnValues {
my @columns = $self->schema->source($source)->columns;
my %unique_constraints = $self->schema->source($source)->unique_constraints();
my $build_value = 3;
# we try max three times if there are unique constraints
my $build_value = 5;
# we try max $build_value times if there are unique constraints
BUILD_VALUE: while ( $build_value ) {
# generate random values for all columns
for my $col_name( @columns ) {
@ -442,7 +442,8 @@ sub _gen_text {
$regex = '[A-Za-z]';
}
my $random = String::Random->new( max => $size );
return $random->randregex($regex);
my $text = $random->randregex($regex);
return $text;
}
sub _gen_set_enum {