Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18286: [QA Follow-up] Fix some warnings from qa tools

Browse source 
[1] Resolve warning on variable assignment before use strict.
[2] Remove unused $schema variable.
[3] Remove eval expression construction.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2017-05-02 15:46:08 +02:00 committed by Jonathan Druart
parent 71c75f4773
commit 70ae3a9dc2
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
t/db_dependent/01-test_dbic.t
View file

@ -1,7 +1,6 @@
#!/usr/bin/perl
# This file is part of Koha.
my $verbose = 0;
use Modern::Perl;
@ -10,12 +9,14 @@ use Test::MockModule;
use Koha::Libraries;
use C4::Context;
Koha::Libraries->search->count;
my $verbose = 0;
subtest "Scenario: Show how caching prevents Test::DBIx::Class from working properly and how to circumvent it", sub {
my ($firstSchema, $schema, $cachedSchema, $cachedSchema2, $firstLibCount, $libCount);
my ($firstSchema, $cachedSchema, $cachedSchema2, $firstLibCount, $libCount);
eval {
@ -74,13 +75,13 @@ subtest "Scenario: Show how caching prevents Test::DBIx::Class from working prop
' And the cached DB connection type is sqlite');
eval "fixtures_ok [ #Dynamically load fixtures, because we dynamically load T:D:C. Otherwise there be compile errors!
fixtures_ok( [ #Dynamically load fixtures, because we dynamically load T:D:C. Otherwise there be compile errors!
Branch => [
['branchcode', 'branchname'],
['XXX_test', 'my branchname XXX'],
]
],
'Step: Given we deploy T:D:C Fixtures';";
'Step: Given we deploy T:D:C Fixtures');
ok($libCount = Koha::Libraries->search->count,
' When the libraries are counted');