Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28373: (follow-up) QA fixes

Browse source 
Use fully qualified subroutine name
Don't return explicit undef

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2021-08-23 14:12:26 +00:00 committed by Jonathan Druart
parent 967244f898
commit 735ce7bd7d
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
t/Search.t
View file

@ -181,9 +181,10 @@ subtest "searchResults PassItemMarcToXSLT test" => sub {
t::lib::Mocks::mock_preference('marcflavour','MARC21');
my $mock_xslt = Test::MockModule->new("C4::Search");
$mock_xslt->mock( XSLTParse4Display => sub {
my (undef, $record) = @_;
my $params = shift;
my $record = $params->{record};
warn $record->field('952') ? "Item here" : "No item";
return undef;
return;
});
my $builder = t::lib::TestBuilder->new;
@ -194,13 +195,13 @@ subtest "searchResults PassItemMarcToXSLT test" => sub {
t::lib::Mocks::mock_preference('PassItemMarcToXSLT','1');
warnings_like { searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
warnings_like { C4::Search::searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
[qr/Item here/],
"Item field returned from default XSLT if pref set";
t::lib::Mocks::mock_preference('PassItemMarcToXSLT','0');
warnings_like { searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
warnings_like { C4::Search::searchResults({ interface => "opac" },"test",1,1,0,0,[ $record->as_xml_record ] ,undef) }
[qr/No item/],
"Item field returned from default XSLT if pref set";