Bug 28772: Make validate_secret return 1|0

Not an empty string

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Koha/ApiKey.pm

@@ -81,7 +81,7 @@ sub validate_secret {
 
     my $digest = Koha::AuthUtils::hash_password( $secret, $self->secret );
 
-    return $self->secret eq $digest;
+    return ( $self->secret eq $digest ) ? 1 : 0;
 }
 
 =head3 plain_text_secret

t/db_dependent/Koha/ApiKey.t

@@ -130,8 +130,8 @@ subtest 'validate_secret() tests' => sub {
 
     my $secret = $api_key->plain_text_secret;
 
-    ok( $api_key->validate_secret( $secret ), 'Valid secret returns true' );
-    ok( !$api_key->validate_secret( 'Wrong secret' ), 'Invalid secret returns false' );
+    is( $api_key->validate_secret( $secret ), 1, 'Valid secret returns true' );
+    is( $api_key->validate_secret( 'Wrong secret' ), 0, 'Invalid secret returns false' );
 
     $schema->storage->txn_rollback;
 };