Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28772: Make validate_secret return 1|0

Browse source 
Not an empty string

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2021-09-10 10:34:41 +02:00 committed by Kyle M Hall
parent cedc953c46
commit 73e806f902
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/ApiKey.pm
View file

@ -81,7 +81,7 @@ sub validate_secret {
my $digest = Koha::AuthUtils::hash_password( $secret, $self->secret ); my $digest = Koha::AuthUtils::hash_password( $secret, $self->secret );
return $self->secret eq $digest; return ( $self->secret eq $digest ) ? 1 : 0;
} }
=head3 plain_text_secret =head3 plain_text_secret

4
t/db_dependent/Koha/ApiKey.t
View file

@ -130,8 +130,8 @@ subtest 'validate_secret() tests' => sub {
my $secret = $api_key->plain_text_secret; my $secret = $api_key->plain_text_secret;
ok( $api_key->validate_secret( $secret ), 'Valid secret returns true' ); is( $api_key->validate_secret( $secret ), 1, 'Valid secret returns true' );
ok( !$api_key->validate_secret( 'Wrong secret' ), 'Invalid secret returns false' ); is( $api_key->validate_secret( 'Wrong secret' ), 0, 'Invalid secret returns false' );
$schema->storage->txn_rollback; $schema->storage->txn_rollback;
}; };