Housekeeping in errors scripts

Enable warnings - remove Bug 2505 FIXME messages
Correct FSF address in License statement
To aid code analysis tools:
Call new unambiguously with arrow syntax
use noninterpolating quotes on noninterpolating strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This commit is contained in:
Colin Campbell 2010-05-12 12:25:41 +01:00 committed by Galen Charlton
parent bf1d430622
commit 743ad9e827
6 changed files with 36 additions and 37 deletions

View file

@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
# Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
#use warnings; FIXME - Bug 2505
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
my $query = new CGI;
my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "errors/400.tmpl",
template_name => 'errors/400.tmpl',
query => $query,
type => "intranet",
type => 'intranet',
authnotrequired => 1,
debug => 1,
}

View file

@ -12,24 +12,23 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
# Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
#use warnings; FIXME - Bug 2505
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
my $query = new CGI;
my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "errors/401.tmpl",
template_name => 'errors/401.tmpl',
query => $query,
type => "intranet",
type => 'intranet',
authnotrequired => 1,
debug => 1,
}

View file

@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
# Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
#use warnings; FIXME - Bug 2505
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
my $query = new CGI;
my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "errors/402.tmpl",
template_name => 'errors/402.tmpl',
query => $query,
type => "intranet",
type => 'intranet',
authnotrequired => 1,
debug => 1,
}

View file

@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
# Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
#use warnings; FIXME - Bug 2505
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
my $query = new CGI;
my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "errors/403.tmpl",
template_name => 'errors/403.tmpl',
query => $query,
type => "intranet",
type => 'intranet',
authnotrequired => 1,
debug => 1,
}

View file

@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
# Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
#use warnings; FIXME - Bug 2505
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
my $query = new CGI;
my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "errors/404.tmpl",
template_name => 'errors/404.tmpl',
query => $query,
type => "intranet",
type => 'intranet',
authnotrequired => 1,
debug => 1,
}

View file

@ -12,24 +12,24 @@
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
# Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
use strict;
#use warnings; FIXME - Bug 2505
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
use C4::Context;
my $query = new CGI;
my $query = CGI->new;
my $admin = C4::Context->preference('KohaAdminEmailAddress');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "errors/500.tmpl",
template_name => 'errors/500.tmpl',
query => $query,
type => "intranet",
type => 'intranet',
authnotrequired => 1,
debug => 1,
}