Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35393: Fix Objects.t - filter_by_last_update

Browse source 
Test plan:
Keep awake until just after midnight :)
Run t/db_dependent/Koha/Objects.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2023-11-24 07:22:48 +00:00 committed by Tomas Cohen Arazi
parent fd55e07435
commit 757be13211
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
t/db_dependent/Koha/Objects.t
View file

@ -1191,7 +1191,7 @@ subtest "filter_by_last_update" => sub {
subtest 'Parameters older_than, younger_than' => sub {
my $now = dt_from_string();
my $rs = Koha::Patrons->search( { borrowernumber => { -in => \@borrowernumbers } } );
$rs->update( { updated_on => $now->clone->subtract( hours => 25 ) } );
$rs->update( { updated_on => $now->clone->subtract( hours => 24 ) } );
is(
$rs->filter_by_last_update( { timestamp_column_name => 'updated_on', from => $now } )->count, 0,
'All updated yesterday'
@ -1208,17 +1208,17 @@ subtest "filter_by_last_update" => sub {
);
is(
$rs->filter_by_last_update(
{ timestamp_column_name => 'updated_on', from => $now->clone->subtract( days => 1 ), }
{ timestamp_column_name => 'updated_on', from => $now->clone->subtract( minutes => 24 * 60 - 1 ), }
)->count,
0,
'Yesterday, not truncated, one hour too late'
'Yesterday + 1m, not truncated, no results'
);
is(
$rs->filter_by_last_update(
{ timestamp_column_name => 'updated_on', from => $now->clone->subtract( hours => 25 ), }
{ timestamp_column_name => 'updated_on', from => $now->clone->subtract( hours => 24 ), }
)->count,
6,
'Yesterday - 1h, not truncated, within time frame'
'Yesterday, not truncated, results'
);
};