Bug 33558: Use template wrapper for breadcrumbs: Serials part 1

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Claims
    - Claims for a vendor
  - Check expiration
  - Subscription details ->
    - Serial collection
    - Create routing list
    - Edit routing list
    - Preview routing list

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt

@@ -1,3 +1,4 @@
+[% USE raw %]
 [% USE Branches %]
 [% USE KohaDates %]
 [% SET footerjs = 1 %]
@@ -12,22 +13,15 @@
 [% END %]
 
 [% WRAPPER 'sub-header.inc' %]
-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
+    [% WRAPPER breadcrumbs %]
-    <ol>
+        [% WRAPPER breadcrumb_item %]
-        <li>
-            <a href="/cgi-bin/koha/mainpage.pl">Home</a>
-        </li>
-        <li>
             <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
-        </li>
-        <li>
-            <a href="#" aria-current="page">
-                Check expiration
-            </a>
-        </li>
-    </ol>
-</nav>
         [% END %]
+        [% WRAPPER breadcrumb_item bc_active= 1 %]
+            <span>Check expiration</span>
+        [% END %]
+    [% END #/ WRAPPER breadcrumbs %]
+[% END #/ WRAPPER sub-header.inc %]
 
 <div class="main container-fluid">
     <div class="row">

koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt

@@ -13,34 +13,28 @@
     [% WRAPPER 'header.inc' %]
     [% INCLUDE 'serials-search.inc' %]
 [% END %]
+
 [% WRAPPER 'sub-header.inc' %]
-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
+    [% WRAPPER breadcrumbs %]
-    <ol>
+        [% WRAPPER breadcrumb_item %]
-        <li>
-            <a href="/cgi-bin/koha/mainpage.pl">Home</a>
-        </li>
-        <li>
             <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
-        </li>
+        [% END %]
         [% IF ( supplierid ) -%]
-            <li>
+            [% WRAPPER breadcrumb_item %]
                 <a href="/cgi-bin/koha/serials/claims.pl">
                     Claims
                 </a>
-            </li>
+            [% END %]
-            <li>
+            [% WRAPPER breadcrumb_item bc_active= 1 %]
-                <a href="#" aria-current="page">Claims for [% suppliername | html %]</a>
+                <span>Claims for [% suppliername | html %]</span>
-            </li>
+            [% END %]
         [% ELSE -%]
-            <li>
+            [% WRAPPER breadcrumb_item bc_active= 1 %]
-                <a href="#" aria-current="page">
+                <span>Claims</span>
-                    Claims
-                </a>
-            </li>
             [% END %]
-    </ol>
-</nav>
         [% END %]
+    [% END #/ WRAPPER breadcrumbs %]
+[% END #/ WRAPPER sub-header.inc %]
 
 <div class="main container-fluid">
     <div class="row">

koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt

@@ -1,3 +1,4 @@
+[% USE raw %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Preview routing list &rsaquo; Serials &rsaquo; Koha</title>
@@ -10,25 +11,18 @@
 [% END %]
 
 [% WRAPPER 'sub-header.inc' %]
-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
+    [% WRAPPER breadcrumbs %]
-    <ol>
+        [% WRAPPER breadcrumb_item %]
-        <li>
-            <a href="/cgi-bin/koha/mainpage.pl">Home</a>
-        </li>
-        <li>
             <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
-        </li>
-        <li>
-            <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a>
-        </li>
-        <li>
-            <a href="#" aria-current="page">
-                Preview routing list
-            </a>
-        </li>
-    </ol>
-</nav>
         [% END %]
+        [% WRAPPER breadcrumb_item %]
+            <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a>
+        [% END %]
+        [% WRAPPER breadcrumb_item bc_active= 1 %]
+            <span>Preview routing list</span>
+        [% END %]
+    [% END #/ WRAPPER breadcrumbs %]
+[% END #/ WRAPPER sub-header.inc %]
 
 <div class="main container-fluid">
     <div class="row">

koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt

@@ -1,3 +1,4 @@
+[% USE raw %]
 [% USE KohaDates %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
@@ -10,39 +11,24 @@
 [% END %]
 
 [% WRAPPER 'sub-header.inc' %]
-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
+    [% WRAPPER breadcrumbs %]
-    <ol>
+        [% WRAPPER breadcrumb_item %]
-        <li>
-            <a href="/cgi-bin/koha/mainpage.pl">Home</a>
-        </li>
-
-        [% IF blocking_error %]
-            <li>
-                <a href="#" aria-current="page">
-                    Serials
-                </a>
-            </li>
-
-        [% ELSE %]
-            <li>
             <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
-            </li>
+        [% END %]
-            <li>
+        [% UNLESS ( blocking_error ) %]
+            [% WRAPPER breadcrumb_item %]
                 <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a>
-            </li>
+            [% END %]
-            <li>
+            [% WRAPPER breadcrumb_item bc_active= 1 %]
-                <a href="#" aria-current="page">
                 [% IF ( op ) %]
                     <span>Create routing list</span>
                 [% ELSE %]
                     <span>Edit routing list</span>
                 [% END %]
-                </a>
-            </li>
-        [% END %]
-    </ol>
-</nav>
             [% END %]
+        [% END # UNLESS blocking_error %]
+    [% END #/ WRAPPER breadcrumbs %]
+[% END #/ WRAPPER sub-header.inc %]
 
 <div class="main container-fluid">
     <div class="row">

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt

@@ -2,6 +2,7 @@
 [% USE Asset %]
 [% USE AuthorisedValues %]
 [% USE Branches %]
+[% USE HtmlTags %]
 [% USE KohaDates %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
@@ -15,22 +16,18 @@
 [% END %]
 
 [% WRAPPER 'sub-header.inc' %]
-    <nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
+    [% WRAPPER breadcrumbs %]
-        <ol>
+        [% WRAPPER breadcrumb_item %]
-            <li>
-                <a href="/cgi-bin/koha/mainpage.pl">Home</a>
-            </li>
-            <li>
             <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
-            </li>
-            <li>
-                <a href="#" aria-current="page">
-                    Serial collection information for <em>[% bibliotitle | html %]</em>
-                </a>
-            </li>
-        </ol>
-    </nav>
         [% END %]
+        [% WRAPPER breadcrumb_item %]
+            <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% bibliotitle | html %]</em></a>
+        [% END %]
+        [% WRAPPER breadcrumb_item bc_active= 1 %]
+            <span>Serial collection information</span>
+        [% END %]
+    [% END #/ WRAPPER breadcrumbs %]
+[% END #/ WRAPPER sub-header.inc %]
 
 <div class="main container-fluid">
     <div class="row">