Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33558: Use template wrapper for breadcrumbs: Serials part 1

Browse source 
This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Claims
    - Claims for a vendor
  - Check expiration
  - Subscription details ->
    - Serial collection
    - Create routing list
    - Edit routing list
    - Preview routing list

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-04-18 13:16:26 +00:00 committed by Tomas Cohen Arazi
parent 449c51b08c
commit 75f30ebd51
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
5 changed files with 65 additions and 100 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
View file

@ -1,3 +1,4 @@
[% USE raw %]
[% USE Branches %] [% USE Branches %]
[% USE KohaDates %] [% USE KohaDates %]
[% SET footerjs = 1 %] [% SET footerjs = 1 %]
@ -12,22 +13,15 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page"> <span>Check expiration</span>
Check expiration [% END %]
</a> [% END #/ WRAPPER breadcrumbs %]
</li> [% END #/ WRAPPER sub-header.inc %]
</ol>
</nav>
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

34
koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
View file

@ -13,34 +13,28 @@
[% WRAPPER 'header.inc' %] [% WRAPPER 'header.inc' %]
[% INCLUDE 'serials-search.inc' %] [% INCLUDE 'serials-search.inc' %]
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
</li> [% END %]
[% IF ( supplierid ) -%] [% IF ( supplierid ) -%]
<li> [% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/serials/claims.pl"> <a href="/cgi-bin/koha/serials/claims.pl">
Claims Claims
</a> </a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page">Claims for [% suppliername | html %]</a> <span>Claims for [% suppliername | html %]</span>
</li> [% END %]
[% ELSE -%] [% ELSE -%]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page"> <span>Claims</span>
Claims [% END %]
</a>
</li>
[% END %] [% END %]
</ol> [% END #/ WRAPPER breadcrumbs %]
</nav> [% END #/ WRAPPER sub-header.inc %]
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

28
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt
View file

@ -1,3 +1,4 @@
[% USE raw %]
[% SET footerjs = 1 %] [% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %] [% INCLUDE 'doc-head-open.inc' %]
<title>Preview routing list &rsaquo; Serials &rsaquo; Koha</title> <title>Preview routing list &rsaquo; Serials &rsaquo; Koha</title>
@ -10,25 +11,18 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a> <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page"> <span>Preview routing list</span>
Preview routing list [% END %]
</a> [% END #/ WRAPPER breadcrumbs %]
</li> [% END #/ WRAPPER sub-header.inc %]
</ol>
</nav>
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

50
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
View file

@ -1,3 +1,4 @@
[% USE raw %]
[% USE KohaDates %] [% USE KohaDates %]
[% SET footerjs = 1 %] [% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %] [% INCLUDE 'doc-head-open.inc' %]
@ -10,39 +11,24 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li> <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
[% IF blocking_error %]
<li>
<a href="#" aria-current="page">
Serials
</a>
</li>
[% ELSE %]
<li>
<a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
</li>
<li>
<a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a>
</li>
<li>
<a href="#" aria-current="page">
[% IF ( op ) %]
<span>Create routing list</span>
[% ELSE %]
<span>Edit routing list</span>
[% END %]
</a>
</li>
[% END %] [% END %]
</ol> [% UNLESS ( blocking_error ) %]
</nav> [% WRAPPER breadcrumb_item %]
[% END %] <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% title | html %]</em></a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
[% IF ( op ) %]
<span>Create routing list</span>
[% ELSE %]
<span>Edit routing list</span>
[% END %]
[% END %]
[% END # UNLESS blocking_error %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

29
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
View file

@ -2,6 +2,7 @@
[% USE Asset %] [% USE Asset %]
[% USE AuthorisedValues %] [% USE AuthorisedValues %]
[% USE Branches %] [% USE Branches %]
[% USE HtmlTags %]
[% USE KohaDates %] [% USE KohaDates %]
[% SET footerjs = 1 %] [% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %] [% INCLUDE 'doc-head-open.inc' %]
@ -15,22 +16,18 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li> <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
<a href="/cgi-bin/koha/mainpage.pl">Home</a> [% END %]
</li> [% WRAPPER breadcrumb_item %]
<li> <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscriptionid | uri %]"><em>[% bibliotitle | html %]</em></a>
<a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a> [% END %]
</li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<li> <span>Serial collection information</span>
<a href="#" aria-current="page"> [% END %]
Serial collection information for <em>[% bibliotitle | html %]</em> [% END #/ WRAPPER breadcrumbs %]
</a> [% END #/ WRAPPER sub-header.inc %]
</li>
</ol>
</nav>
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">