diff --git a/reports/dictionary.pl b/reports/dictionary.pl index 86bbf1e5fd..8803482774 100755 --- a/reports/dictionary.pl +++ b/reports/dictionary.pl @@ -81,8 +81,8 @@ if ( $op eq 'add_form' ) { my $columnstring = join( ',', @columns ); my $forbidden = Koha::Report->new->check_columns( undef, \@columns ); my @column_loop; - foreach my $column (@columns) { - unless ($forbidden) { + unless ($forbidden) { + foreach my $column (@columns) { my %tmp_hash; $tmp_hash{'name'} = $column; my $type = get_column_type($column); @@ -112,16 +112,7 @@ if ( $op eq 'add_form' ) { 'columnstring' => $columnstring, ); } else { - my $columns = get_columns( $area, $input ); - $template->param( - 'step_3' => 1, - 'area' => $area, - 'definition_name' => $definition_name, - 'definition_description' => $definition_description, - 'columns' => \@column_loop, - 'columnstring' => $columnstring, - 'passworderr' => 1, - ); + $template->param( 'new_dictionary' => 1, passworderr => 1 ); } } elsif ( $op eq 'cud-add_form_5' ) {