Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15980: Use Font Awesome icons in subscription frequency deletion confirmation dialog

Browse source 
If you try to delete a subscription frequency which is in use by an
existing subscription you will be shown a confirmation dialog. This
dialog should use Font Awesome icons.

Other minor changes:

- Added "action" attributes to <form>s to fix validation errors.
- Added "alert" class to confirmation dialog so that it is correctly
  styled.

To test, apply the patch and go to Serials -> Frequencies.

- Click "Delete" on a frequency which is in use by a subscription.
- Verify that the confirmation dialog is styled correctly.
- Test that the "No, do not delete" button works correctly.
- Test that the "Yes, delete" button deletes the correct frequency.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
This commit is contained in:
Owen Leonard 2016-03-04 11:37:42 -05:00 committed by Brendan Gallagher
parent 364844cfd7
commit 7742d8911b
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
View file

@ -163,7 +163,7 @@ $(document).ready(function() {
<h1>Frequencies</h1>
[% IF still_used %]
<div class="dialog">
<div class="dialog alert">
<p>
This frequency is still used by [% subscriptions.size %]
subscription(s). Do you still want to delete it?
@ -177,14 +177,14 @@ $(document).ready(function() {
[% END %]
</ul>
<form action="" method="get">
<form action="/cgi-bin/koha/serials/subscription-frequencies.pl" method="get">
<input type="hidden" name="op" value="del" />
<input type="hidden" name="confirm" value="1" />
<input type="hidden" name="frequencyid" value="[% frequencyid %]" />
<input type="submit" class="approve" value="Yes, delete" />
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button>
</form>
<form action="" method="get">
<input type="submit" class="deny" value="No, don't delete" />
<form action="/cgi-bin/koha/serials/subscription-frequencies.pl" method="get">
<button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
</form>
</div>
[% END %]