Bug 33145: Fix ERM swagger specs
This patch adds the missing 'Provider name' parameter definition to the
various ERM paths that were missing it.
Test plan
1) Run:
docker run --rm -v $PWD/api/v1/swagger:/swagger \
jeanberu/swagger-cli \
swagger-cli validate swagger/swagger.yaml
=> FAIL: The spec is not valid!
2) Apply this patch
3) Repeat 1
=> SUCCESS: Tests pass!
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: tcohen edited the test plan because of the failure to install
swagger-cli cleanly
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 79f7f44aa1
)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
This commit is contained in:
parent
fce06269e1
commit
780d51e75e
3 changed files with 35 additions and 1 deletions
|
@ -113,6 +113,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- description: A JSON object containing information about the new package
|
||||
in: body
|
||||
name: body
|
||||
|
@ -229,6 +234,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- $ref: "../swagger.yaml#/parameters/eholdings_package_id_pp"
|
||||
- name: body
|
||||
in: body
|
||||
|
@ -291,6 +301,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- $ref: "../swagger.yaml#/parameters/eholdings_package_id_pp"
|
||||
responses:
|
||||
204:
|
||||
|
|
|
@ -190,6 +190,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- description: A JSON object containing information about the new title
|
||||
in: body
|
||||
name: body
|
||||
|
@ -304,6 +309,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- $ref: "../swagger.yaml#/parameters/eholdings_title_id_pp"
|
||||
- name: body
|
||||
in: body
|
||||
|
@ -366,6 +376,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- $ref: "../swagger.yaml#/parameters/eholdings_title_id_pp"
|
||||
responses:
|
||||
204:
|
||||
|
@ -403,7 +418,6 @@
|
|||
x-koha-authorization:
|
||||
permissions:
|
||||
erm: 1
|
||||
|
||||
/erm/eholdings/local/titles/import:
|
||||
post:
|
||||
x-mojo-to: ERM::EHoldings::Titles#import_from_list
|
||||
|
|
|
@ -9,6 +9,11 @@
|
|||
produces:
|
||||
- application/json
|
||||
parameters:
|
||||
- description: Provider name
|
||||
in: path
|
||||
name: provider
|
||||
required: true
|
||||
type: string
|
||||
- description: Case insensitive search on resource_id
|
||||
in: query
|
||||
name: resource_id
|
||||
|
|
Loading…
Reference in a new issue