Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12933: (QA followup) Rename parse_letter to parse_overdues_letter

Browse source 
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Kyle Hall 2015-01-01 18:48:03 -05:00 committed by Tomas Cohen Arazi
parent 492e524799
commit 78db3adda2
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
C4/Overdues.pm
View file

@ -57,7 +57,7 @@ BEGIN {
&RemoveNotifyLine
&AddNotifyLine
&GetOverdueMessageTransportTypes
&parse_letter
&parse_overdues_letter
);
# subs to remove
@ -955,7 +955,7 @@ sub GetOverdueMessageTransportTypes {
return \@mtts;
}
=head2 parse_letter
=head2 parse_overdues_letter
parses the letter template, replacing the placeholders with data
specific to this patron, biblio, or item for overdues
@ -971,7 +971,7 @@ substituted keys and values.
=cut
sub parse_letter {
sub parse_overdues_letter {
my $params = shift;
foreach my $required (qw( letter_code borrowernumber )) {
return unless ( exists $params->{$required} && $params->{$required} );

4
members/print_overdues.pl
View file

@ -25,7 +25,7 @@ use C4::Context;
use C4::Auth;
use C4::Output;
use C4::Members qw(GetOverdues);
use C4::Overdues qw(parse_letter);
use C4::Overdues qw(parse_overdues_letter);
my $input = new CGI;
@ -47,7 +47,7 @@ my $branchcode = C4::Context->userenv->{'branch'};
my $overdues = GetOverdues($borrowernumber);
my $letter = parse_letter(
my $letter = parse_overdues_letter(
{
letter_code => 'OVERDUES_SLIP',
borrowernumber => $borrowernumber,

2
misc/cronjobs/overdue_notices.pl
View file

@ -672,7 +672,7 @@ END_SQL
my $print_sent = 0; # A print notice is not yet sent for this patron
for my $mtt ( @message_transport_types ) {
my $letter = parse_letter(
my $letter = parse_overdues_letter(
{ letter_code => $overdue_rules->{"letter$i"},
borrowernumber => $borrowernumber,
branchcode => $branchcode,