Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31908: Add a test to show issue

Browse source 
Test plan:
Without next patch, run Auth.t.
Should fail now before next patch resolves problem:
    not ok 2 - Login of patron2 approved
    ok 3 - Did not return previous session ID
    not ok 4 - New session ID not empty

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2022-11-14 11:07:09 +00:00 committed by Tomas Cohen Arazi
parent c70977f5fe
commit 795b4cb6de
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 44 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
t/db_dependent/Auth.t
View file

@ -41,7 +41,7 @@ $schema->storage->txn_begin;
subtest 'checkauth() tests' => sub {
plan tests => 6;
plan tests => 7;
my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => undef } });
@ -152,6 +152,49 @@ subtest 'checkauth() tests' => sub {
};
};
subtest 'While still logged in, relogin with another user' => sub {
plan tests => 4;
my $patron = $builder->build_object({ class => 'Koha::Patrons', value => {} });
my $patron2 = $builder->build_object({ class => 'Koha::Patrons', value => {} });
# Create 'former' session
my $session = C4::Auth::get_session();
$session->param( 'number', $patron->id );
$session->param( 'id', $patron->userid );
$session->param( 'ip', '1.2.3.4' );
$session->param( 'lasttime', time() );
$session->param( 'interface', 'opac' );
$session->flush;
my $sessionID = $session->id;
C4::Context->_new_userenv($sessionID);
my ( $return ) = C4::Auth::check_cookie_auth( $sessionID, undef, { skip_version_check => 1, remote_addr => '1.2.3.4' } );
is( $return, 'ok', 'Former session in shape now' );
my $mock1 = Test::MockModule->new('C4::Auth')->mock( 'safe_exit', sub {} );
my $mock2 = Test::MockModule->new('CGI') ->mock( 'request_method', 'POST' )
->mock( 'cookie', sub { return $sessionID; } ); # oversimplified..
my $cgi = CGI->new;
my $password = 'Incr3d1blyZtr@ng93$';
$patron2->set_password({ password => $password });
$cgi->param( -name => 'userid', -value => $patron2->userid );
$cgi->param( -name => 'password', -value => $password );
$cgi->param( -name => 'koha_login_context', -value => 1 );
my @return;
{
local *STDOUT;
local %ENV;
$ENV{REMOTE_ADDR} = '1.2.3.4';
my $stdout;
open STDOUT, '>', \$stdout;
@return = C4::Auth::checkauth( $cgi, 0, {} );
close STDOUT;
}
# Note: We can test return values from checkauth here since we mocked the safe_exit after the Redirect 303
is( $return[0], $patron2->userid, 'Login of patron2 approved' );
isnt( $return[2], $sessionID, 'Did not return previous session ID' );
ok( $return[2], 'New session ID not empty' );
};
subtest 'Two-factor authentication' => sub {
plan tests => 18;