Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.

Browse source 
Duplicates the code for searching by reviewer in the form that is used in searching via a link.

It looks like it was the intention of the original writer to filter by borrower number or by name.  Filtering by name was not implemented.  Added a FIXME reference to indicate this.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This commit is contained in:
Garry Collum 2010-02-15 10:43:23 -05:00 committed by Galen Charlton
parent 3cdbce6919
commit 79b8a27c0c
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tags/review.pl
View file

@ -178,11 +178,12 @@ if ($filter = $input->param('to')) {
}
}
if ($filter = $input->param('approver')) { # name (or borrowernumber) from input box
if (($filter =~ /^\d+$/ and $filter > 0) or
(1) ){ # $filter=get borrowernumber from name
if ($filter =~ /^\d+$/ and $filter > 0) {
# $filter=get borrowernumber from name
# FIXME: get borrowernumber from name not implemented.
$template->param(filter_approver=>$filter);
$filters{approved_by} = $filter;
# } else {
} else {
push @errors, {approver=>$filter};
}
}