Bug 26963: (QA follow-up) Fix cases where we expected a list

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Koha/Biblio.pm

@@ -220,7 +220,7 @@ sub pickup_locations {
 
     my @pickup_locations;
     foreach my $item_of_bib ($self->items->as_list) {
-        push @pickup_locations, @{ $item_of_bib->pickup_locations( {patron => $patron} ) };
+        push @pickup_locations, @{ $item_of_bib->pickup_locations( {patron => $patron} )->as_list() };
     }
 
     my %seen;

Koha/Template/Plugin/Branches.pm

@@ -117,7 +117,7 @@ sub pickup_locations {
         if ($item) {
             $item = Koha::Items->find($item)
               unless ref($item) eq 'Koha::Item';
-            @libraries = @{ $item->pickup_locations( { patron => $patron } ) }
+            @libraries = $item->pickup_locations( { patron => $patron } )
               if defined $item;
         }
         elsif ($biblio) {

reserve/request.pl

@@ -572,7 +572,7 @@ foreach my $biblionumber (@biblionumbers) {
                         $item->{pickup_locations_code} = 'all';
                     } else {
                         my $arr_locations = Koha::Items->find($itemnumber)
-                                    ->pickup_locations( { patron => $patron } );
+                                    ->pickup_locations( { patron => $patron } )->as_list();
 
                         $item->{pickup_locations} = join( ', ',
                             map { $_->unblessed->{branchname} } @$arr_locations);