Bug 18582 - Hide empty rows in detailed suggestion view
This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
parent
4e9701c36a
commit
7bcc226fac
1 changed files with 54 additions and 11 deletions
|
@ -210,16 +210,54 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
|
|||
<fieldset class="rows">
|
||||
<legend>Bibliographic information</legend>
|
||||
<ol>
|
||||
<li><span class="label">Title:</span>[% title |html %]</li>
|
||||
<li><span class="label">Author:</span>[% author |html %]</li>
|
||||
<li><span class="label">Copyright date:</span>[% copyrightdate |html %]</li>
|
||||
<li><span class="label">ISBN or ISSN or other standard number:</span>[% isbn |html %]</li>
|
||||
<li><span class="label">Publisher:</span>[% publishercode |html %]</li>
|
||||
<li><span class="label">Publication place:</span>[% place |html %]</li>
|
||||
<li><span class="label">Collection title:</span>[% collectiontitle |html %]</li>
|
||||
<li><span class="label">Document type:</span>
|
||||
[% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', itemtype, 0 ) %]
|
||||
</li>
|
||||
[% IF ( title ) %]
|
||||
<li>
|
||||
<span class="label">Title:</span>
|
||||
[% title |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( author ) %]
|
||||
<li>
|
||||
<span class="label">Author:</span>
|
||||
[% author |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( copyrightdate ) %]
|
||||
<li>
|
||||
<span class="label">Copyright date:</span>
|
||||
[% copyrightdate |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( isbn ) %]
|
||||
<li>
|
||||
<span class="label">ISBN or ISSN or other standard number:</span>
|
||||
[% isbn |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( publishercode ) %]
|
||||
<li>
|
||||
<span class="label">Publisher:</span>
|
||||
[% publishercode |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( place ) %]
|
||||
<li>
|
||||
<span class="label">Publication place:</span>
|
||||
[% place |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( collectiontitle ) %]
|
||||
<li>
|
||||
<span class="label">Collection title:</span>
|
||||
[% collectiontitle |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( itemtype ) %]
|
||||
<li>
|
||||
<span class="label">Document type:</span>
|
||||
[% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', itemtype, 0 ) %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF ( patron_reason_loop ) %]
|
||||
<li><span class="label">Reason for suggestion: </span>
|
||||
[% FOREACH patron_reason_loo IN patron_reason_loop %]
|
||||
|
@ -227,7 +265,12 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
|
|||
[% END %]
|
||||
</li>
|
||||
[% END %]
|
||||
<li><span class="label">Notes:</span>[% note |html %]</li>
|
||||
[% IF ( note ) %]
|
||||
<li>
|
||||
<span class="label">Notes:</span>
|
||||
[% note |html %]
|
||||
</li>
|
||||
[% END %]
|
||||
</ol>
|
||||
</fieldset>
|
||||
<fieldset class="rows"> <legend>Suggestion management</legend>
|
||||
|
|
Loading…
Reference in a new issue