Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31095: Remove GetDebarments from Patron::Import

Browse source 
This patch replaced GetDebarments with $patron->restrictions->search in
Koha::Patron::Import.

Test plan
1. Confirm that importing patrons with debarred and debarredcomment
   fields in the import still works as expected

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9ea8cf0a8f)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Martin Renvoize 2022-08-25 08:56:54 +01:00 committed by Matt Blenkinsop
parent 1d6c3d29b1
commit 7c8b170ddb
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Koha/Patrons/Import.pm
View file

@ -29,7 +29,7 @@ use C4::Letters qw( GetPreparedLetter EnqueueLetter );
use Koha::Libraries;
use Koha::Patrons;
use Koha::Patron::Categories;
use Koha::Patron::Debarments qw( AddDebarment GetDebarments );
use Koha::Patron::Debarments qw( AddDebarment );
use Koha::DateUtils qw( dt_from_string output_pref );
=head1 NAME
@ -293,16 +293,15 @@ sub import_patrons {
if ( $borrower{debarred} && ( ( $borrower{debarred} ne $member->{debarred} ) || ( $borrower{debarredcomment} ne $member->{debarredcomment} ) ) ) {
# Check to see if this debarment already exists
my $debarrments = GetDebarments(
my $restrictions = $patron->restrictions->search(
{
borrowernumber => $borrowernumber,
expiration => $borrower{debarred},
comment => $borrower{debarredcomment}
expiration => $borrower{debarred},
comment => $borrower{debarredcomment}
}
);
# If it doesn't, then add it!
unless (@$debarrments) {
unless ($restrictions->count) {
AddDebarment(
{
borrowernumber => $borrowernumber,