Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 23051: (follow-up) Remove call to GetFines

Browse source 
As mentioned by Nick in comment #69 and subsequently discussed on Slack,
the call to GetFines in renew_item was unnececcesary. It has now been
removed.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Andrew Isherwood 2020-03-05 10:26:38 +00:00 committed by Martin Renvoize
parent cc8f2cb50d
commit 7d2a5ef865
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Koha/Account/Line.pm
View file

@ -827,15 +827,6 @@ sub renew_item {
my $itemnumber = $self->item->itemnumber;
my $borrowernumber = $self->patron->borrowernumber;
# Only do something if this item has no fines left on it
my $fine = C4::Overdues::GetFine($itemnumber, $borrowernumber);
if ($fine && $fine > 0) {
return {
itemnumber => $itemnumber,
error => 'has_fine',
success => 0
};
}
my ( $can_renew, $error ) = C4::Circulation::CanBookBeRenewed(
$borrowernumber,
$itemnumber