Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10023: Change degree notation for number to No.

Browse source 
This patch changes N<little circle> to No. in three templates.

To test:
1) Search for a vendor with visible baskets.
   Check that the first column of the basket table in the
   is now labelled No.

2) Print a PDF order in acquisitons with layout2pages.

3) Print a PDF oder in acquisitons with layout3pages.

Check both generated PDFs for the correct syntax.

Note: you need to switch the system preference
OrderPdfFormat in order to test 2) and 3).
The 2 possible settings are:
pdfformat::layout3pages
pdfformat::layout2pages

It's not only Koha - git bz doesn't like the degree
notation either.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I prefer "No." over "#" and my survey of the templates shows that "No."
appears more often. Looks like something to add to our style guide.
Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
Katrin Fischer 2013-04-14 16:29:40 +02:00 committed by Jared Camins-Esakov
parent 3b45b745cf
commit 7d3d347774
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
acqui/pdfformat/layout2pages.pm
View file

@ -82,7 +82,7 @@ sub printorders {
my $abaskets; my $abaskets;
my $arrbasket; my $arrbasket;
my @keys = ('Basket#', 'Document', 'Qty', 'RRP tax inc.', 'Discount', 'GST', 'Total tax exc.', 'Total tax inc.'); my @keys = ('Basket (No.)', 'Document', 'Qty', 'RRP tax inc.', 'Discount', 'GST', 'Total tax exc.', 'Total tax inc.');
for my $bkey (@keys) { for my $bkey (@keys) {
push(@$arrbasket, $bkey); push(@$arrbasket, $bkey);
} }

2
acqui/pdfformat/layout3pages.pm
View file

@ -92,7 +92,7 @@ sub printorders {
# add basketgroup number # add basketgroup number
$text->font( $pdf->corefont("Times", -encoding => "utf8"), 6/mm ); $text->font( $pdf->corefont("Times", -encoding => "utf8"), 6/mm );
$text->translate(20/mm, ($height-15)/mm); $text->translate(20/mm, ($height-15)/mm);
$text->text("Order# ".$basketgroup->{'id'}.". Basket# ".$basket->{basketno}.". ".$basket->{booksellernote}); $text->text("Order no. ".$basketgroup->{'id'}.". Basket no. ".$basket->{basketno}.". ".$basket->{booksellernote});
$text->translate(20/mm, ($height-20)/mm); $text->translate(20/mm, ($height-20)/mm);
$text->font( $pdf->corefont("Times", -encoding => "utf8"), 4/mm ); $text->font( $pdf->corefont("Times", -encoding => "utf8"), 4/mm );
$text->text( ( $basket->{billingplace} ? "Billing at " . C4::Branch::GetBranchName( $basket->{billingplace} ) : "" ) $text->text( ( $basket->{billingplace} ? "Billing at " . C4::Branch::GetBranchName( $basket->{billingplace} ) : "" )

2
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
View file

@ -87,7 +87,7 @@ $(document).ready(function() {
<table class="baskets"> <table class="baskets">
<thead> <thead>
<tr> <tr>
<th>#</th> <th>No.</th>
<th>Name</th> <th>Name</th>
<th>Item count</th> <th>Item count</th>
<th>Biblio count</th> <th>Biblio count</th>