Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29234: Further clean Z3950 Tests

Browse source 
We are deleting all authorised values in Session2.t and assuming they don't exist in Sesson.t

This patch ensures the tests will work regardless of data in DB

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2023-04-03 13:15:24 +00:00 committed by Tomas Cohen Arazi
parent b96e61f1ea
commit 7d50f85cc6
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 33 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
t/db_dependent/Koha/Z3950Responder/Session.t
View file

@ -54,6 +54,10 @@ subtest 'add_item_status' => sub {
my $item_field_2 = scalar $item_marc_2->field($itemtag);
## END SECOND ITEM ##
# We want to test the default values, so we remove custom status alias if present
my $available = Koha::AuthorisedValues->find({ category => 'Z3950_STATUS', authorised_value => 'AVAILABLE' });
$available->delete if $available;
# Create the responder
my $args={ PEER_NAME => 'PEER'};
my $zR = Koha::Z3950Responder->new({add_item_status_subfield => 'k'});

24
t/db_dependent/Koha/Z3950Responder/Session2.t
View file

@ -5,6 +5,7 @@ use Test::More tests => 3;
use t::lib::TestBuilder;
use C4::Items qw( GetMarcItem );
use Koha::AuthorisedValues;
use Koha::Caches;
BEGIN {
@ -25,23 +26,32 @@ subtest 'add_item_status' => sub {
plan tests => 2;
# This time we are sustituting some values
$builder->schema->resultset( 'AuthorisedValue' )->delete_all();
$builder->build({
source => 'AuthorisedValue',
my $available = Koha::AuthorisedValues->find({ category => 'Z3950_STATUS', authorised_value => 'AVAILABLE' });
unless( $available ){
$available = $builder->build_object({
class => 'Koha::AuthorisedValues',
value => {
category => 'Z3950_STATUS',
authorised_value => 'AVAILABLE',
lib => "Free as a bird"
}
});
$builder->build({
source => 'AuthorisedValue',
}
my $available_status = $available->lib;
my $damaged = Koha::AuthorisedValues->find({ category => 'Z3950_STATUS', authorised_value => 'DAMAGED' });
unless( $damaged ){
$damaged = $builder->build_object({
class => 'Koha::AuthorisedValues',
value => {
category => 'Z3950_STATUS',
authorised_value => 'DAMAGED',
lib => "Borked completely"
}
});
}
my $damaged_status = $damaged->lib;
## FIRST ITEM HAS ALL THE STATUSES ##
my $item_1 = $builder->build_sample_item(
@ -81,10 +91,10 @@ subtest 'add_item_status' => sub {
$zR->init_handler($args);
$args->{HANDLE}->add_item_status($item_field_1);
is($item_field_1->subfield('k'),"Checked Out, Lost, Not for Loan, Borked completely, Withdrawn, In Transit, On Hold","All statuses added in one field as expected");
is($item_field_1->subfield('k'),"Checked Out, Lost, Not for Loan, $damaged_status, Withdrawn, In Transit, On Hold","All statuses added in one field as expected");
$args->{HANDLE}->add_item_status($item_field_2);
is($item_field_2->subfield('k'),'Free as a bird',"Available status is 'Free as a bird' added as expected");
is($item_field_2->subfield('k'),"$available_status","Available status is '$available_status' added as expected");
};