Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled

Browse source 
This patch hides the Article requests column in the large circulation
rules table when the ArticleRequests system preference is disabled.

To test:
0) Apply patch
1) With ArticleRequests disabled, go to Administration > Circulation and fines
   rules
2) Scroll right in the first table
--> There isn't any mention of article requests in the table
3) Scroll down to see the other tables in the page
--> There are no other article requests tables
4) Enable ArticleRequests in Administration > System preferences
5) Go back to the Circulation and fines rules and refresh the page
6) Scroll right in the first table
--> There should be an article requests yes/no column
7) Scroll down to see the other tables in the page
--> There are other article requests tables, Default open article requests
    limit and Default article request fees

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4b875fa936)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Caroline Cyr La Rose 2022-08-03 09:54:27 -04:00 committed by Lucas Gass
parent 7459cbd399
commit 7d571ca2c0
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
View file

@ -141,7 +141,9 @@
<th>Holds per record (count)</th> <th>Holds per record (count)</th>
<th>On shelf holds allowed</th> <th>On shelf holds allowed</th>
<th>OPAC item level holds</th> <th>OPAC item level holds</th>
[% IF Koha.Preference('ArticleRequests') %]
<th>Article requests</th> <th>Article requests</th>
[% END %]
<th>Rental discount (%)</th> <th>Rental discount (%)</th>
[% IF Koha.Preference('UseRecalls') %] [% IF Koha.Preference('UseRecalls') %]
<th>Recalls allowed (total)</th> <th>Recalls allowed (total)</th>
@ -361,6 +363,7 @@
<span>Don't allow</span> <span>Don't allow</span>
[% END %] [% END %]
</td> </td>
[% IF Koha.Preference('ArticleRequests') %]
<td> <td>
[% IF article_requests == 'no' %] [% IF article_requests == 'no' %]
<span>No</span> <span>No</span>
@ -372,6 +375,7 @@
<span>Item only</span> <span>Item only</span>
[% END %] [% END %]
</td> </td>
[% END %]
<td>[% rentaldiscount | html %]</td> <td>[% rentaldiscount | html %]</td>
[% IF Koha.Preference('UseRecalls') %] [% IF Koha.Preference('UseRecalls') %]
<td>[% recalls_allowed | html %]</td> <td>[% recalls_allowed | html %]</td>
@ -507,6 +511,7 @@
<option value="F">Force</option> <option value="F">Force</option>
</select> </select>
</td> </td>
[% IF Koha.Preference('ArticleRequests') %]
<td> <td>
<select id="article_requests" name="article_requests"> <select id="article_requests" name="article_requests">
<option value="no">No</option> <option value="no">No</option>
@ -515,6 +520,7 @@
<option value="item_only">Item only</option> <option value="item_only">Item only</option>
</select> </select>
</td> </td>
[% END %]
<td><input type="text" name="rentaldiscount" id="rentaldiscount" size="2" /></td> <td><input type="text" name="rentaldiscount" id="rentaldiscount" size="2" /></td>
[% IF Koha.Preference('UseRecalls') %] [% IF Koha.Preference('UseRecalls') %]
<td><input type="text" name="recalls_allowed" id="recalls_allowed" size="3"></td> <td><input type="text" name="recalls_allowed" id="recalls_allowed" size="3"></td>
@ -573,7 +579,9 @@
<th>Holds per record (count)</th> <th>Holds per record (count)</th>
<th>On shelf holds allowed</th> <th>On shelf holds allowed</th>
<th>OPAC item level holds</th> <th>OPAC item level holds</th>
[% IF Koha.Preference('ArticleRequests') %]
<th>Article requests</th> <th>Article requests</th>
[% END %]
<th>Rental discount (%)</th> <th>Rental discount (%)</th>
[% IF Koha.Preference('UseRecalls') %] [% IF Koha.Preference('UseRecalls') %]
<th>Recalls allowed (total)</th> <th>Recalls allowed (total)</th>