Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34552: Don't exclude payments with no status

Browse source 
Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 6ee6bea6bf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Nick Clemens 2023-08-25 15:51:12 +00:00 committed by Fridolin Somers
parent cdb5734ade
commit 7d977be3e9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reports/cash_register_stats.pl
View file

@ -83,7 +83,7 @@ if ($do_it) {
}
if ( $transaction_type eq 'PAYMENT' || $transaction_type eq 'ACT' ) {
$whereTType .= q{ AND status != 'VOID' };
$whereTType .= q{ AND (status != 'VOID' OR status IS NULL) };
}
my $whereBranchCode = q{};