Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31482: Label creator does not call barcodedecode

Browse source 
The label creator can accept a list of either itemnumbers or item barcodes.
In the case that the list of composed of barcodes, those barcodes should be
passed though barcodedecode before the lookup is performed.

Test Plan:
1) Apply this patch
2) Download and install the Barcode Transformer plugin
   https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/
3) Go to the plugin configuration page, set the configuration to the example configuration from the same page
4) On the "New label batch" page of the Label creator,,
   type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y
5) Submit the form
6) Note the items are added to the label batch!

JK: Remove unnecessary if $number check, barcodedecode already does this

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Kyle Hall 2022-08-29 09:26:44 -04:00 committed by Tomas Cohen Arazi
parent c575f86198
commit 7ddfa8ddd7
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
labels/label-edit-batch.pl
View file

@ -23,9 +23,10 @@ use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Auth qw( get_template_and_user );
use C4::Output qw( output_html_with_http_headers );
use C4::Circulation qw( barcodedecode );
use C4::Creators qw( get_label_summary html_table );
use C4::Labels;
use C4::Output qw( output_html_with_http_headers );
use Koha::Items;
@ -89,6 +90,7 @@ elsif ($op eq 'add') {
push @item_numbers, $number;
}
elsif ($number_type eq "barcode" ) { # we must test in case an invalid barcode is passed in; we effectively disgard them atm
$number = barcodedecode($number);
my $item = Koha::Items->find({barcode => $number});
push @item_numbers, $item->itemnumber if $item;
}