Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called

Browse source 
Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl
(the only places where it is used in the code even) instead of
'xsl_syspref' that is actually used and this is the cause of those
warnings.

Also added honeypot to check if other calls in same way happens.
Honeypot probably not needed, review when QA in the Community.

To reproduce (shelves.pl):
1) Prepare some test list with items or use existing one.
2) Go to the lists page (koha/virtualshelves/shelves.pl),
notice multitude of new warnings in the "intranet-error.log" log file
that mostly have to do with "Use of uninitialized value $xslsyspref".
3) Apply the patch.
4) Go back to same page and check it again, warns like that should not
appear in the log file anymore.

To reproduce (opac-tags.pl):
1) Go to the "my tags" page in OPAC and open "tag cloud".
2) Notice a bunch of new warnings in the log file that mostly have to
do with "Use of uninitialized value $xslsyspref".
3) Apply the patch.
4) Reload the page and check the log file again.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Petro Vashchuk 2021-12-09 15:47:07 +02:00 committed by Fridolin Somers
parent de487dac12
commit 81bb6761a2
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
C4/XSLT.pm
View file

@ -251,6 +251,9 @@ sub XSLTParse4Display {
my $variables = $params->{xslt_variables};
my $items_rs = $params->{items_rs};
die "Mandatory \$params->{xsl_syspref} was not provided, called with biblionumber $params->{biblionumber}"
if not defined $params->{xsl_syspref};
my $xslfilename = get_xsl_filename( $xslsyspref);
# grab the XML, run it through our stylesheet, push it out to the browser

2
opac/opac-tags.pl
View file

@ -292,7 +292,7 @@ if ($loggedinuser) {
{
biblionumber => $tag->{biblionumber},
record => $record,
xsl_filename => 'OPACXSLTResultsDisplay',
xsl_syspref => 'OPACXSLTResultsDisplay',
fix_amps => 1,
hidden_items => $hidden_items,
xslt_variables => $variables

2
virtualshelves/shelves.pl
View file

@ -268,7 +268,7 @@ if ( $op eq 'view' ) {
{
biblionumber => $biblionumber,
record => $record,
xsl_filename => "XSLTListsDisplay",
xsl_syspref => 'XSLTListsDisplay',
fix_amps => 1,
}
);