Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP

Browse source 
Caused by
  commit ab47e46ea0
  Bug 18789: Pass a Koha::Patron object from returns.pl

circ/returns.pl does not send a $patron Koha::Patron object to the
template in case print_slip is set

Test plan:
Confirm a hold and print the slip

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2018-05-28 15:11:09 -03:00 committed by Nick Clemens
parent 96070c9ea4
commit 82a4f23ee3
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
circ/returns.pl
View file

@ -78,7 +78,7 @@ if ($session->param('branch') eq 'NO_LIBRARY_SET'){
if ( $query->param('print_slip') ) {
$template->param(
print_slip => 1,
borrowernumber => scalar $query->param('borrowernumber'),
borrowernumber => scalar $query->param('borrowernumber'), # FIXME We should send a Koha::Patron and raise an error if not exist.
biblionumber => scalar $query->param('biblionumber'),
);
}

2
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
View file

@ -709,7 +709,7 @@
$(".modal").on('hidden.bs.modal', function (e) { $("#barcode").focus(); });
[% IF print_slip %]
Dopop('hold-transfer-slip.pl?borrowernumber=[% patron.borrowernumber %]&amp;biblionumber=[% biblionumber %]');
Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&amp;biblionumber=[% biblionumber %]');
[% END %]
var columns_settings = [% ColumnsSettings.GetColumns( 'circ', 'returns', 'checkedintable', 'json' ) %]