Browse Source

Bug 13420: Sort "Serial enumeration" by published date

So far the sorting on volume information is incorrect. It sorts by the
string displayed in the cell, which may not have any logics.

A better solution would be to use Kyle's suggestion, see comments 7, 8,
but it will need much more work.

This patch suggests to use the publication date to sort this column.
Note: In the code there is a switch depending on the existence of
items.publisheddate, but I do not think it is valid, this valid should
always exist if the item is received (did I miss something?)

Test plan:
You need to have different existing subscription, using different
numbering.
On the detail page of the bibliographic record you should be able to
sort the serials (tab "Holdings") by "Serial enumeration".
The sort will now use the publication dates.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
20.05.x
Jonathan Druart 4 years ago
committed by Martin Renvoize
parent
commit
82f7f7f7d3
Signed by: martin.renvoize GPG Key ID: 422B469130441A0F
  1. 4
      koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

4
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

@ -229,7 +229,7 @@
<th>Home library</th>
[% IF ( itemdata_ccode ) %]<th>Collection</th>[% END %]
<th>Call number</th>
[% IF ( volinfo ) %]<th>Serial enumeration / chronology</th>[% END %]
[% IF volinfo %]<th class="title-string">Serial enumeration / chronology</th>[% END %]
<th>Status</th>
<th class="title-string">Last seen</th>
<th class="title-string">Date accessioned</th>
@ -286,6 +286,7 @@ Note that permanent location is a code, and location may be an authval.
<td class="itemcallnumber">[% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %]</td>
[% IF ( volinfo ) %]
<td class="enumchron">
<span title="[% item.publisheddate | html %]">
[% IF ( itemdata_enumchron ) %]
[% IF item.enumchron && item.serialseq %]
<span class="enum">[% item.enumchron | html %]</span>
@ -302,6 +303,7 @@ Note that permanent location is a code, and location may be an authval.
<span class="pubdate">([% item.publisheddate | $KohaDates %])</span>
[% END %]
[% END %]
</span>
</td>
[% END %]
<td class="status">

Loading…
Cancel
Save