Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34724: Remove inline onclick handler for opac-imageviewer.pl

Browse source 
This patch moves the click handler for thumbnails for opac-imageviewer.pl
out of the inline HTML and out to an existing <script> element.

Test plan:
0. Apply the patch (including dependent patches)
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=localcover
2. Change both *LocalCoverImages sysprefs to "Show"
3. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=AllowMultipleCovers
4. Change "AllowMultipleCovers" to "Allow"
5. Go to
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29
6. Click "Images (0)" tab
7. Download or make two JPEG images
8. Upload the images
9. Go to http://localhost:8080/cgi-bin/koha/opac-imageviewer.pl?biblionumber=29
10. See one large image in the centre and two smaller thumbnails on the right side
11. Click on the thumbnail of the image that isn't displayed in the centre
12. Note that the image changes
13. Click the other thumbnail and note that the image changes back

PA amended patch: Added missing test plan step

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
David Cook 2023-09-06 06:40:21 +00:00 committed by Tomas Cohen Arazi
parent 9e39d2d671
commit 847b5f0777
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-imageviewer.tt
View file

@ -87,7 +87,7 @@
<div class="col-lg-3">
<div id="thumbnails">
[% FOREACH image IN images %]
<a href="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblionumber | url %]&amp;imagenumber=[% image.imagenumber| uri %]" onclick="showCover([% image.imagenumber| html %]); return false;">
<a class="cover_thumbnail" data-imagenumber="[% image.imagenumber| html %]" href="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblionumber | url %]&amp;imagenumber=[% image.imagenumber| uri %]">
[% IF loop.first %]
<img class="thumbnail selected" id="[% image.imagenumber| html %]" src="/cgi-bin/koha/opac-image.pl?imagenumber=[% image.imagenumber | html %]&amp;thumbnail=1" alt="Thumbnail"/>
[% ELSE %]
@ -113,6 +113,13 @@
$(document).ready(function(){
$("#largeCoverImg").attr("src","[% interface | html %]/[% theme | html %]/images/loading.gif");
showCover([% imagenumber | html %]);
$("a.cover_thumbnail").on('click',function(){
let imagenumber = this.dataset.imagenumber;
if (imagenumber){
showCover(imagenumber);
}
return false;
});
});
function showCover(img) {