Bug 35278: Fix warn from column_settings.pl
We need to add scalar to the calls. These parameters are not meant to be used as multi_param. Test plan: Try With and without this patch on staff: Try: /cgi-bin/koha/admin/columns_settings.pl => WITHOUT: No warnings => WITH: Same. No change. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&page=basket => WITHOUT: Opens module, scrolls down. CGI::param called in list context in logfile => WITH: Opens module, scrolls down. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&page=basket&table=orders => WITHOUT: Opens module, scrolls down. CGI::param called in list context in logfile => WITH: Opens module, scrolls down. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&module=admin * Hash like: panel => acqui, admin => page, undef => table, undef => modules, $modules (SHIFTED) => WITHOUT: Acqui expanded showing: There is no page using the table configuration in this module. => CGI::param warning in log. => And: Problem = a value of table has been passed to param without key => And: Problem = a value of modules has been passed to param without key => WITH: Only the first module (Acqui) should be expanded. Try: /cgi-bin/koha/admin/columns_settings.pl?module=acqui&module=admin&page=basket&table=orders * Hash like: panel => acqui, admin => page, basket => table, orders => modules, $modules hash (SHIFTED) => WITHOUT: Acqui expanded showing: There is no page using the table configuration in this module. => And: CGI param log warning. => WITH:: Opens Acqui. Second module ignored. Scrolling. Try: /cgi-bin/koha/admin/columns_settings.pl?module=admin&module=acqui&page=basket&table=orders * Hash like: panel => admin, acqui=> page, basket => table, orders => modules, $modules hash (SHIFTED) => WITHOUT: Admin expanded showing: There is no page using the table configuration in this module. => And: CGI param log warning. => WITH: Admin should be expanded (page and table ignored, not in Admin). No scroll. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit1b11de87b9
) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commitdbc24ece69
) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
This commit is contained in:
parent
9c93df0b07
commit
8500168c89
1 changed files with 3 additions and 3 deletions
|
@ -74,9 +74,9 @@ if ( $action eq 'save' ) {
|
|||
if ( $action eq 'list' ) {
|
||||
my $modules = C4::Utils::DataTables::TablesSettings::get_modules;
|
||||
$template->param(
|
||||
panel => defined $input->param('module') ? $input->param('module') : undef,
|
||||
page => defined $input->param('page') ? $input->param('page') : undef,
|
||||
table => defined $input->param('table') ? $input->param('table') : undef,
|
||||
panel => scalar $input->param('module'),
|
||||
page => scalar $input->param('page'),
|
||||
table => scalar $input->param('table'),
|
||||
modules => $modules,
|
||||
);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue