Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 26903: Pass record ids and records through to update_index when passed to index_records

Browse source 
When both a record and record_id are passed to index_records the data should be passed through
to update_index. We missed copying over the record ids to the variable we use as a check.

To test:
1 - Set searchEngine system preference to Elasticsearch
2 - Reindex your db
3 - Search authorities
4 - Edit a record and add 'testwaffle' to the main heading
5 - Search authorities for 'testwaffle' - no results
6 - Apply patch
7 - Edit the record again, change 'testwaffle' to 'testpancake'
8 - Search authorities for 'testpancake' - result!
9 - Confirm imported authorities and authorities added via Z39 are correctly indexed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-11-13 16:33:40 +00:00 committed by Jonathan Druart
parent 8a955f9a0a
commit 853a56cc7a
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Koha/SearchEngine/Elasticsearch/Indexer.pm
View file

@ -101,7 +101,6 @@ sub update_index {
my $documents = $self->marc_records_to_documents($records);
my @body;
for (my $i = 0; $i < scalar @$biblionums; $i++) {
my $id = $biblionums->[$i];
my $document = $documents->[$i];
@ -302,7 +301,9 @@ sub index_records {
$records = [$records] if ref $records ne 'ARRAY' && defined $records;
if ( $op eq 'specialUpdate' ) {
my $index_record_numbers;
unless ($records) {
if ($records){
$index_record_numbers = $record_numbers;
} else {
foreach my $record_number ( @$record_numbers ){
my $record = _get_record( $record_number, $server );
if( $record ){