Browse Source

Bug 11827: Make "Cancel Rating" translatable in jQuery rating plugin

- Make the "Cancel rating" text translatable (and change
  capitalization to conform to Koha coding guidelines)
- Improve the two other messages to use formatted strings
  instead of concatenation.
- Use the exact same text for the "your rating" text, so it
  only appears once in the po-file.

Test plan:

1. See that the "Cancel rating" -text doesn't appear in
   po/xx-YY-opac-bootstrap.po
2. Note how there's two versions of the your rating -text
   ("your rating: %s, " and "your rating:") in the po-file
3. Apply patch
4. Update the xx-YY translation
5. Check the po-file. It should now contain the "Cancel rating"
   and a single "your rating: %s, "
6. Translate those texts, and update & install the language.
7. Go to the OPAC detail page of a biblio, and check the
   rating texts.
8. Hovering over the rating minus -sign should show the translated
   "Cancel rating"
9. Check that the text after the stars is correct with and without
   your rating

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
18.05.x
Pasi Kallinen 5 years ago
committed by Jonathan Druart
parent
commit
8622f4be59
  1. 5
      koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

5
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt

@ -1654,6 +1654,7 @@
$(function () {
$(".auto-submit-star").rating({
cancel: _('Cancel rating'),
callback: function (value, link) {
// if the new value equals the old value, dont execute callback...
@ -1676,12 +1677,12 @@
$("#rating_value").val(data.rating_value);
if (data.rating_value) {
$("#rating_value_text").text(_("your rating: ") + data.rating_value + ", ");
$("#rating_value_text").text(_("your rating: %s, ").format(data.rating_value));
} else {
$("#rating_value_text").text('');
}
$("#rating_text").text(_("average rating: ") + data.rating_avg + " (" + data.rating_total + ' ' + _("votes") + ")");
$("#rating_text").text(_("average rating: %s (%s votes)").format(data.rating_avg, data.rating_total));
}
}, "json");

Loading…
Cancel
Save