Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21610: (QA follow-up) Better use columns_info from DBIx

Browse source 
We should better use the published method than a private hash key.
And shorter to go via _result than adding a new schema call.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2018-10-19 11:05:50 +02:00 committed by root
parent abb51797d8
commit 8625eefc76
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Koha/Object.pm
View file

@ -121,8 +121,7 @@ Returns:
sub store {
my ($self) = @_;
my $columns_info = Koha::Database->new->schema->resultset( $self->_type )
->result_source->{_columns};
my $columns_info = $self->_result->result_source->columns_info;
# Handle not null and default values for integers and dates
foreach my $col ( keys %{$columns_info} ) {