Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant

Browse source 
Several warnings like:
Variable "$confirm_pref" is not available at /usr/share/koha/masterclone/acqui/basket.pl line 507.

Primarily caused by sub edi_close_and_order.

Easy fix.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2017-01-06 13:36:35 +01:00 committed by Kyle M Hall
parent 14a78a8c52
commit 8639a64bdb
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
acqui/basket.pl
View file

@ -69,13 +69,13 @@ the supplier this script have to display the basket.
=cut
my $query = new CGI;
our $query = new CGI;
our $basketno = $query->param('basketno');
my $ean = $query->param('ean');
my $booksellerid = $query->param('booksellerid');
our $ean = $query->param('ean');
our $booksellerid = $query->param('booksellerid');
my $duplinbatch = $query->param('duplinbatch');
my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
our ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
{
template_name => "acqui/basket.tt",
query => $query,
@ -86,7 +86,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
}
);
my $basket = GetBasket($basketno);
our $basket = GetBasket($basketno);
$booksellerid = $basket->{booksellerid} unless $booksellerid;
my $bookseller = Koha::Acquisition::Booksellers->find( $booksellerid );
my $schema = Koha::Database->new()->schema();
@ -112,7 +112,7 @@ unless (CanUserManageBasket($loggedinuser, $basket, $userflags)) {
# warn "=>".$basket->{booksellerid};
my $op = $query->param('op') // 'list';
my $confirm_pref= C4::Context->preference("BasketConfirmations") || '1';
our $confirm_pref= C4::Context->preference("BasketConfirmations") || '1';
$template->param( skip_confirm_reopen => 1) if $confirm_pref eq '2';
my @messages;