Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 16389: Reports row limit should change upon option selection

Browse source 
To test:
1) Run a report
2) Confirm there is no 'Update' button next to the 'Rows per page:' dropdown
3) Change the limit (i.e. to 10)
4) Confirm the page updates itself

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Aleisha 2016-04-29 03:00:28 +00:00 committed by Kyle M Hall
parent 75cff6cac7
commit 8682a9f821
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
View file

@ -67,6 +67,9 @@ function load_group_subgroups () {
}
$(document).ready(function(){
$('#limit').change(function() {
$('#limitselect').submit();
});
$(".goback").on("click",function(e){
e.preventDefault();
@ -807,7 +810,7 @@ canned reports and writing custom SQL reports.</p>
[% IF ( unlimited_total ) %]<p>Total number of rows matching the (unlimited) query is [% unlimited_total %].</p>[% END %]
<pre id="sql_output">[% sql |html %]</pre>
<form action="/cgi-bin/koha/reports/guided_reports.pl" method="get">
<form action="/cgi-bin/koha/reports/guided_reports.pl" method="get" id="limitselect">
<input type="hidden" name="phase" value="Run this report"/>
<input type="hidden" name="reports" value="[% report_id %]"/>
@ -816,7 +819,7 @@ canned reports and writing custom SQL reports.</p>
[% END %]
<label for="limit">Rows per page: </label>
<select name="limit">
<select name="limit" id="limit">
[% limits = [ 10, 20, 50, 100, 200, 300, 400, 500, 1000 ] %]
[% FOREACH l IN limits %]
[% IF l == limit %]
@ -826,8 +829,6 @@ canned reports and writing custom SQL reports.</p>
[% END %]
[% END %]
</select>
<input type="submit" value="Update" />
</form>
<div class="pages">[% pagination_bar %]</div>