Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37419: Update FK constraint on record sources to avoid data loss

Browse source 
Without this patch, deleting a record source will delete the associated
biblio_metadata rows, which is a severe data loss.

This patch makes the constraint restrict this action.

To test:
1. Add a record source
2. Set the record source to some records
   $ koha-mysql kohadev
   > UPDATE biblio_metadata SET record_source_id='your source id' WHERE
biblionumber=1;
3. Delete the record source
=> FAIL: Record metadata deleted
4. Apply this patch
5, Run:
   $ ktd --shell
  k$ updatedatabase
=> SUCCESS: DB update goes well
6. Repeat 1~3 with another record
=> SUCCESS: Source cannot be deleted if there are linked records

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Tomás Cohen Arazi 2024-07-29 08:12:56 -03:00 committed by Katrin Fischer
parent f4d248f076
commit 8754458775
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 30 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
installer/data/mysql/atomicupdate/bug_37419.pl Executable file
View file

@ -0,0 +1,29 @@
use Modern::Perl;
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
return {
bug_number => "37419",
description => "Replace FK constraint to avoid data loss",
up => sub {
my ($args) = @_;
my ( $dbh, $out ) = @$args{qw(dbh out)};
# Drop table constraint
if ( foreign_key_exists( 'biblio_metadata', 'record_metadata_fk_2' ) ) {
$dbh->do(
q{
ALTER TABLE biblio_metadata DROP FOREIGN KEY record_metadata_fk_2
}
);
}
$dbh->do(
q{
ALTER TABLE biblio_metadata
ADD CONSTRAINT `record_metadata_fk_2` FOREIGN KEY (`record_source_id`) REFERENCES `record_sources` (`record_source_id`) ON DELETE RESTRICT ON UPDATE CASCADE
}
);
say_success( $out, "Updated foreign key 'biblio_metadata.record_metadata_fk_2'" );
},
};

2
installer/data/mysql/kohastructure.sql
View file

@ -1144,7 +1144,7 @@ CREATE TABLE `biblio_metadata` (
KEY `timestamp` (`timestamp`),
KEY `record_metadata_fk_2` (`record_source_id`),
CONSTRAINT `record_metadata_fk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE,
CONSTRAINT `record_metadata_fk_2` FOREIGN KEY (`record_source_id`) REFERENCES `record_sources` (`record_source_id`) ON DELETE CASCADE ON UPDATE CASCADE
CONSTRAINT `record_metadata_fk_2` FOREIGN KEY (`record_source_id`) REFERENCES `record_sources` (`record_source_id`) ON DELETE RESTRICT ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
/*!40101 SET character_set_client = @saved_cs_client */;