Browse Source

Bug 17356: [QA Follow-up] Minor changes to skeleton.perl

Due to the way the snippet is run, there is no need to add a use for
C4::Installer or define $dbh (just like $DBVersion).
The suggested code is commented (column_exists is not defined).
Just as in updatedatabase, CheckVersion is called. The version number
does not need to contain 16.06; if we do so, we should update this
number each release. The XXX's work just fine.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
16.11.x
Marcel de Rooy 5 years ago
committed by Kyle M Hall
parent
commit
8767434021
  1. 20
      installer/data/mysql/atomicupdate/skeleton.perl

20
installer/data/mysql/atomicupdate/skeleton.perl

@ -1,10 +1,14 @@
use C4::Installer;
my $dbh = C4::Context->dbh;
$DBversion = '16.06.00.XXX';
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
unless( column_exists( 'biblio', 'biblionumber' ) ) { # or constraint_exists( $table_name, $key_name )
warn "There is something wrong";
}
SetVersion ($DBversion);
$DBversion = 'XXX'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
# you can use $dbh here like:
# $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" );
# or perform some test and warn
# if( !column_exists( 'biblio', 'biblionumber' ) ) {
# warn "There is something wrong";
# }
# Always end with this (adjust the bug info)
SetVersion( $DBversion );
print "Upgrade to $DBversion done (Bug XXXXX - description)\n";
}

Loading…
Cancel
Save