Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 22947: Markup error in OPAC preferences file

Browse source 
This patch corrects a markup error in the OPAC .pref file which can
cause display problems. The patch also corrects a validator warning by
changing at <tt> to a <code>.

To reproduce the problem, go to Administration -> Global system
preferences -> OPAC.

Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."

This patch addresses two specific errors:

 - "Unclosed element code."
 - "The tt element is obsolete. Use CSS instead."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the display.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Owen Leonard 2019-05-21 13:19:17 +00:00 committed by Martin Renvoize
parent 1653ae8871
commit 87cbb27826
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
View file

@ -121,7 +121,7 @@ OPAC:
no: "Don't include"
- "COinS / OpenURL / Z39.88 in OPAC search results. <br/>Warning: Enabling this feature will slow OPAC search response times."
- "<br/>If you want to display a link to an OpenURL resolver, look at the following system preferences:"
- "<br/><code>OpenURLResolverURL</code>, <code>OPACShowOpenURL</code>, <code>OPACOpenURLItemTypes</code>, <code>OpenURLText<code>, <code>OpenURLImageLocation</code>"
- "<br/><code>OpenURLResolverURL</code>, <code>OPACShowOpenURL</code>, <code>OPACOpenURLItemTypes</code>, <code>OpenURLText</code>, <code>OpenURLImageLocation</code>"
-
- pref: OPACShowUnusedAuthorities
choices:
@ -639,7 +639,7 @@ OPAC:
- Define custom rules to hide specific items from search and view on the OPAC. How to write these rules is documented on the <a href="http://wiki.koha-community.org/wiki/OpacHiddenItems" target="_blank">Koha wiki</a>.
-
- pref: OpacHiddenItemsExceptions
- List of borrower categories, separated by |, that can see items otherwise hidden by <tt>OpacHiddenItems</tt>
- List of borrower categories, separated by |, that can see items otherwise hidden by <code>OpacHiddenItems</code>
-
- pref: OpacAllowPublicListCreation
default: 1