Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21203: ILS-DI - Make GetRecords handle non-existent records

Browse source 
Caused by
  commit cb336e633b
  Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem

Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 212

Test plan:
- Enable ilsdi
- hit /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=X
With X an existing biblionumber and a non existing one

Both requests must succeed

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2018-08-10 12:17:45 -03:00 committed by Nick Clemens
parent f130ada624
commit 88d3865168
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
C4/ILSDI/Services.pm
View file

@ -209,14 +209,13 @@ sub GetRecords {
# Get the biblioitem from the biblionumber
my $biblio = Koha::Biblios->find( $biblionumber );
my $biblioitem = $biblio->biblioitem;
if ( $biblioitem ) {
$biblioitem = $biblioitem->unblessed;
} else {
$biblioitem->{code} = "RecordNotFound";
# FIXME We should not need to process something else; next?
unless ( $biblio ) {
push @records, { code => "RecordNotFound" };
next;
}
my $biblioitem = $biblio->biblioitem->unblessed;
my $embed_items = 1;
my $record = GetMarcBiblio({
biblionumber => $biblionumber,