Bug 34436: Some breadcrumbs lack <span> for translatability

This patch modifies several templates which were updated recently so
that breadcrumbs markup could be built using template wrappers. The
patch wraps strings in <span> in cases where it is necessary to make
them translatable.

To test, apply the patch and view the following pages to confirm that
the breadcrumbs still show up correctly:

- Administration -> MARC bibliographic framework
  - Add framework
  - Edit framework
  - Delete framework
- Administration -> Share content with Mana KB
- Administration -> Circulation and fine rules
- Authorities ->
  - Add authority
  - Edit authority
- Catalog -> Advanced search
  - Bibliographic detail page
    - Must have EasyAnalyticalRecords enabled.
    - Edit -> Link to host record
- Patrons
- Reports -> Average loan time
- Serials -> Serials home

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt

@@ -37,11 +37,11 @@
             [% END %]
             [% IF framework %]
                 [% WRAPPER breadcrumb_item bc_active= 1 %]
-                    Modify framework text
+                    <span>Modify framework text</span>
                 [% END %]
             [% ELSE %]
                 [% WRAPPER breadcrumb_item bc_active= 1 %]
-                    Add framework
+                    <span>Add framework</span>
                 [% END %]
             [% END %]
 
@@ -50,12 +50,12 @@
                 <a href="/cgi-bin/koha/admin/biblio_framework.pl">MARC frameworks</a>
             [% END %]
             [% WRAPPER breadcrumb_item bc_active= 1 %]
-                Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])?
+                <span>Delete framework for [% framework.frameworktext | html %]</span> ([% framework.frameworkcode | html %])?
             [% END %]
 
         [% ELSE %]
             [% WRAPPER breadcrumb_item bc_active= 1 %]
-                MARC frameworks
+                <span>MARC frameworks</span>
             [% END %]
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]

koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt

@@ -23,7 +23,7 @@
             <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
         [% END %]
         [% WRAPPER breadcrumb_item bc_active= 1 %]
-            Share content with Mana KB
+            <span>Share content with Mana KB</span>
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]
 [% END #/ WRAPPER sub-header.inc %]

koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt

@@ -44,7 +44,7 @@
             <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
        [% END %]
         [% WRAPPER breadcrumb_item bc_active= 1 %]
-            Circulation and fine rules
+            <span>Circulation and fine rules</span>
        [% END %]
     [% END #/ WRAPPER breadcrumbs %]
 [% END #/ WRAPPER sub-header.inc %]

koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt

@@ -361,12 +361,12 @@
 
         [% IF ( authid ) %]
             [% WRAPPER breadcrumb_item bc_active= 1 %]
-                Modify authority #[% authid | html %] ([% authtypetext | html %])
+                <span>Modify authority #[% authid | html %]</span> ([% authtypetext | html %])
             [% END %]
 
         [% ELSE %]
             [% WRAPPER breadcrumb_item bc_active= 1 %]
-                Adding authority [% authtypetext | html %]
+                <span>Adding authority [% authtypetext | html %]</span>
             [% END %]
 
         [% END %]

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt

@@ -33,7 +33,7 @@
 [% WRAPPER 'sub-header.inc' %]
     [% WRAPPER breadcrumbs %]
         [% WRAPPER breadcrumb_item bc_active= 1 %]
-            Advanced search
+            <span>Advanced search</span>
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]
 [% END #/ WRAPPER sub-header.inc %]

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt

@@ -15,7 +15,7 @@
             <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a>
         [% END %]
         [% WRAPPER breadcrumb_item bc_active= 1 %]
-            Link a host record to [% bibliotitle | html %]
+            <span>Link a host record to [% bibliotitle | html %]</span>
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]
 [% END #/ WRAPPER sub-header.inc %]

koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt

@@ -24,7 +24,7 @@
 [% WRAPPER 'sub-header.inc' %]
     [% WRAPPER breadcrumbs %]
         [% WRAPPER breadcrumb_item bc_active= 1 %]
-            Patrons
+            <span>Patrons</span>
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]
 [% END #/ WRAPPER sub-header.inc %]

koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt

@@ -21,11 +21,11 @@
                 <a href="/cgi-bin/koha/reports/issues_avg_stats.pl">Average loan time</a>
             [% END %]
             [% WRAPPER breadcrumb_item bc_active= 1 %]
-                Results
+                <span>Results</span>
             [% END %]
         [% ELSE %]
             [% WRAPPER breadcrumb_item bc_active= 1 %]
-                Average loan time
+                <span>Average loan time</span>
             [% END %]
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt

@@ -16,7 +16,7 @@
 [% WRAPPER 'sub-header.inc' %]
     [% WRAPPER breadcrumbs %]
         [% WRAPPER breadcrumb_item bc_active= 1 %]
-            Serials
+            <span>Serials</span>
         [% END %]
     [% END #/ WRAPPER breadcrumbs %]
 [% END #/ WRAPPER sub-header.inc %]