Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 17234: Two new functions lack tests

Browse source 
This adds two tests to t/db_dependent/Installer.t

TEST PLAN
---------
1) Apply patch
2) prove -v t/db_dependent/Installer.t
   -- column and constraint tests were added.
3) run koha qa test tools

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Mark Tompsett 2016-12-30 14:08:33 -05:00 committed by Kyle M Hall
parent 0b15c5e2cc
commit 8938631f38
1 changed files with 54 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

63
t/db_dependent/Installer.t
View file

@ -1,13 +1,29 @@
#!/usr/bin/perl
#
# This Koha test module is a stub!
# This file is part of Koha.
#
# Copyright (C) 2014 Aleisha Amohia (Bug 11541)
# Copyright (C) 2016 Mark Tompsett (Bug 17234)
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
# This Koha test module is still a stub!
# Add more tests here!!!
# Bug 11541
use strict;
use warnings;
use Test::More tests => 9;
use Modern::Perl;
use Test::More tests => 11;
use Koha::Database;
BEGIN {
use_ok('C4::Installer');
@ -15,9 +31,32 @@ BEGIN {
ok( my $installer = C4::Installer->new(), 'Testing NewInstaller' );
is( ref $installer, 'C4::Installer', 'Testing class of object' );
is ( $installer->{'dbname'}, C4::Context->config("database"), 'Testing DbName' );
is ( $installer->{'dbms'}, C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' );
is ( $installer->{'hostname'}, C4::Context->config("hostname"), 'Testing Hostname' );
is ( $installer->{'port'}, C4::Context->config("port"), 'Testing Port' );
is ( $installer->{'user'}, C4::Context->config("user"), 'Testing User' );
is ( $installer->{'password'}, C4::Context->config("pass"), 'Testing Password' );
is( $installer->{'dbname'}, C4::Context->config('database'), 'Testing DbName' );
is(
$installer->{'dbms'},
C4::Context->config('db_scheme')
? C4::Context->config('db_scheme')
: 'mysql',
'Testing DbScheme'
);
is(
$installer->{'hostname'},
C4::Context->config('hostname'),
'Testing Hostname'
);
is( $installer->{'port'}, C4::Context->config('port'), 'Testing Port' );
is( $installer->{'user'}, C4::Context->config('user'), 'Testing User' );
is( $installer->{'password'}, C4::Context->config('pass'), 'Testing Password' );
# The borrower table is known to have columns and constraints.
my $schema = Koha::Database->new->schema;
my $source = $schema->source('Borrower');
my @column_names = $source->columns();
my $column_name = $column_names[0];
ok( column_exists( 'borrowers', $column_name ), 'Known column does exist' );
my @constraint_names = $source->unique_constraint_names();
my $constraint_name = $constraint_names[0];
ok( constraint_exists( 'borrowers', $constraint_name ),
'Known constraint does exist' );